Add debugging, stop hang in ProcessInThread.#139
Open
nwp90 wants to merge 1 commit into
Open
Conversation
FMCorz
force-pushed
the
master
branch
4 times, most recently
from
87b93e4 to
0a1b6c2
Compare
nwp90
force-pushed
the
nwp90-fix-hang
branch
from
80a45e0 to
8553751
Compare
nwp90
force-pushed
the
nwp90-fix-hang
branch
from
8553751 to
09a7ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a few problems getting things going with mdk - this fixes them.
Added a little debugging (which should only show when debug is configured anyway) to make it clearer what's going on.
2 problems fixed:
if something is already listening on the port selenium wants to use, selenium dies immediately. This caused an exception when trying to kill a nonexistent process.
hung in "while True" loop. Which is unnecessary & inefficient anyway. proc.poll() check was incorrect (should have checked for "is not None"), but using communicate() is simpler, easier to read, more efficient etc. anyway.