Add RSA settings - #15
Open
shashankk42 wants to merge 2 commits into
Open
Conversation
This was referenced Apr 3, 2026
bvanessen
force-pushed
the
feature/rsa-settings
branch
from
May 1, 2026 20:47
afcf0c8 to
84e6a32
Compare
tbennun
requested changes
May 12, 2026
tbennun
left a comment
tbennun
left a comment
Collaborator
There was a problem hiding this comment.
A few unnecessary changes. This PR should be redone in the context of the FLASK-Copilot PR
Comment on lines
+106
to
+107
| except (RuntimeError, Exception) as send_error: | ||
| logger.debug( |
Collaborator
There was a problem hiding this comment.
Isn't RuntimeError a subclass of Exception?
| ) | ||
| except (RuntimeError, Exception) as send_error: | ||
| logger.debug( | ||
| f"Could not send error to WebSocket (likely closed): {send_error}" |
Collaborator
There was a problem hiding this comment.
also, this should be logger.exception
Comment on lines
+114
to
+117
| except (RuntimeError, Exception) as send_error: | ||
| logger.debug( | ||
| f"Could not send complete to WebSocket (likely closed): {send_error}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
I don't see a reason to change any of these lines
| "message": {"source": source, "message": msg, **kwargs}, | ||
| } | ||
| ) | ||
| except (RuntimeError, Exception): |
Collaborator
There was a problem hiding this comment.
again, the two might not be necessary
Comment on lines
+99
to
+103
| except (RuntimeError, Exception) as e: | ||
| # WebSocket is closed or disconnected - log to console but don't raise | ||
| logger.debug( | ||
| f"Could not send message to WebSocket (likely closed): {str(e)}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
logger.exception and one Exception please
Comment on lines
+104
to
+105
| # Unbind the websocket so we don't keep trying to send to it | ||
| self.websocket = None |
Collaborator
There was a problem hiding this comment.
This is a bad assumption that should be removed
Collaborator
There was a problem hiding this comment.
Looks like this is a duplicate of the FLASK-Copilot settings panel. I think this one is the only one that should exist, so the other one should be removed.
Comment on lines
+51
to
+55
| useRsa?: boolean; | ||
| rsaMode?: 'standalone' | 'rag'; | ||
| rsaN?: number; | ||
| rsaK?: number; | ||
| rsaT?: number; |
Collaborator
There was a problem hiding this comment.
This means that the type changes in FLASK-Copilot are unnecessary
bvanessen
force-pushed
the
feature/rsa-settings
branch
from
May 12, 2026 21:04
f140619 to
b8d712f
Compare
shashankk42
force-pushed
the
feature/rsa-settings
branch
from
May 19, 2026 21:50
c3e5b2d to
d022c5d
Compare
shashankk42
changed the title
This was referenced May 19, 2026
tbennun
approved these changes
May 23, 2026
shashankk42
force-pushed
the
feature/rsa-settings
branch
from
June 1, 2026 02:48
89a7b13 to
b1416f6
Compare
tbennun
requested changes
Jun 1, 2026
tbennun
left a comment
tbennun
left a comment
Collaborator
There was a problem hiding this comment.
Too many unrelated changes
Comment on lines
+106
to
+107
| except (RuntimeError, Exception) as send_error: | ||
| logger.debug( |
| ) | ||
| except (RuntimeError, Exception) as send_error: | ||
| logger.debug( | ||
| f"Could not send error to WebSocket (likely closed): {send_error}" |
| tb = "".join(traceback.format_exception(exc)) | ||
| msg = f"Background task failed with exception: {type(exc).__name__}: {tb}" | ||
| logger.error(msg) | ||
| await self.websocket.send_json( |
Collaborator
There was a problem hiding this comment.
Unrelated changes to the PR should be reverted and uploaded as a separate PR with sufficient reasoning and or a failing case.
Comment on lines
+8
to
+32
| @@ -19,6 +24,11 @@ | |||
| "@typescript-eslint/semi": "warn", // Changes "semi" rule violations to warnings | |||
| "@typescript-eslint/quotes": ["warn", "double"], // Example of a rule with options as a warning | |||
| "@typescript-eslint/no-unused-vars": "warn", // Changes "no-unused-vars" to a warning | |||
| "@typescript-eslint/no-explicit-any": "warn" // Changes "no-explicit-any" to a warning - // eslint-disable-line @typescript-eslint/no-explicit-any | |||
| "@typescript-eslint/no-explicit-any": "warn", // Changes "no-explicit-any" to a warning - // eslint-disable-line @typescript-eslint/no-explicit-any | |||
| "react/react-in-jsx-scope": "off", | |||
| "react-hooks/rules-of-hooks": "warn", | |||
| "react/no-unescaped-entities": "warn", | |||
| "react/display-name": "warn", | |||
| "react/prop-types": "warn" | |||
Collaborator
There was a problem hiding this comment.
Why were these lines changed?
shashankk42
force-pushed
the
feature/rsa-settings
branch
from
June 1, 2026 19:12
b1416f6 to
07a4dd4
Compare
Author
Reverted non-RSA diffs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
RsaSettingsPanel: a reusable UI component for configuring Recursive Self-Aggregation (RSA) parameters. Imported byFLASK-Copilot's retrosynthesis tab.
Changes
lcc_ui_components/src/RsaSettingsPanel.tsx: new component: checkbox to enable RSA, mode selector (standalone / RAG), andvalidated N / K / T inputs (each ≥ 2, with K ≤ N)
lcc_ui_components/src/index.ts— export the new componentRelated PRs
import { RsaSettingsPanel } from 'lc-conductor')