Skip to content

RSA Support: Fix OpenAI client compatibility and session handling for RSA retrosynthesis #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shashankk42 wants to merge 3 commits into from
Closed

RSA Support: Fix OpenAI client compatibility and session handling for RSA retrosynthesis #120

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3020932
Restore OpenAIResponsesClient to fix tool calling failures in RSA pro…
Apr 2, 2026
c945255
Fix OpenAIResponsesClient parameter from model_id to model
Apr 2, 2026
6bcfc14
Fix session reset between retries and add temperature=0.8 for RSA pro…
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions charge/clients/agentframework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,19 +233,26 @@ def _create_agent(
agent_name: str,
reasoning_effort: Literal["low", "medium", "high"],
instructions: str,
temperature: Optional[float] = None,
) -> AFAgent:
default_options = {
"reasoning": {
"effort": reasoning_effort,
"summary": "detailed",
},
"include": ["reasoning.encrypted_content"],
}

# Add temperature if specified
if temperature is not None:
default_options["temperature"] = temperature

af_agent = AFAgent[OpenAIChatOptions](
client=self.client,
name=agent_name,
instructions=instructions,
tools=self.workbenches,
default_options={
"reasoning": {
"effort": reasoning_effort,
"summary": "detailed",
},
"include": ["reasoning.encrypted_content"],
},
default_options=default_options,
context_providers=[
# This provider ensures session.state contains the history
InMemoryHistoryProvider(load_messages=True)
Expand Down Expand Up @@ -344,8 +351,12 @@ async def _execute_with_retries(
try:
logger.info(f"Attempt {attempt}/{self.max_retries}")

# Create fresh session for retry attempts to avoid orphaned tool calls
# from previous failed attempts (which cause "No tool output found" errors)
retry_session = agent.create_session() if attempt > 1 else session

# Run agent (Agent Framework returns AgentResponse)
stream = await agent.run(user_prompt, session=session, stream=True)
stream = await agent.run(user_prompt, session=retry_session, stream=True)
tool_call_names: dict[str, str] = {}
async for update in stream:
if not update.contents:
Expand Down Expand Up @@ -546,8 +557,10 @@ async def run(
instructions = (
self.task.get_system_prompt() if self.task is not None else ""
)
# Get temperature from task if available
temperature = getattr(self.task, "temperature", None)
self._af_agent = self._create_agent(
self.agent_name, self.reasoning_effort, instructions=instructions
self.agent_name, self.reasoning_effort, instructions=instructions, temperature=temperature
)
self._agent_signature = agent_signature

Expand Down Expand Up @@ -605,7 +618,7 @@ class AgentFrameworkBackend(AgentBackend):
api_key: Optional API key.
base_url: Optional base URL for custom endpoints.
model_kwargs: Additional client kwargs.
use_responses_api: (DEPRECATED in AF) Whether to use Responses API.
use_responses_api: (Deprecated) Whether to use Responses API.
"""

AGENT_COUNT = 0
Expand Down