Skip to content

Update to typescript 6, strict mode on backend and lint #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itamaroryan wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to typescript 6, strict mode on backend and lint #2156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2f41a0
Update to typescript 6, strict mode on backend and lint
itamaroryan Jul 3, 2026
e21b76a
Merge branch 'main' into chore/typescript-6
johnmeshulam Jul 4, 2026
aee7a31
CR fixes
itamaroryan Jul 4, 2026
2cfdf13
Run formatting on the repo
itamaroryan Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
35 changes: 21 additions & 14 deletions apps/admin/src/app/[locale]/(dashboard)/components/widgets/current-season.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,25 @@ export default async function CurrentSeasonWidget() {
<Stack
spacing={1}
sx={{
alignItems: "center",
textAlign: "center"
}}>
alignItems: 'center',
textAlign: 'center'
}}
>
<Typography
variant="h6"
sx={{
color: "error.main",
color: 'error.main',
fontWeight: 600
}}>
}}
>
{t('error')}
</Typography>
<Typography variant="body2" sx={{
color: "text.secondary"
}}>
<Typography
variant="body2"
sx={{
color: 'text.secondary'
}}
>
{t('error-description')}
</Typography>
</Stack>
Expand Down Expand Up @@ -62,11 +67,12 @@ export default async function CurrentSeasonWidget() {
<CardContent sx={{ height: '100%', display: 'flex', alignItems: 'center' }}>
<Box
sx={{
display: "flex",
alignItems: "center",
display: 'flex',
alignItems: 'center',
gap: 3,
width: "100%"
}}>
width: '100%'
}}
>
<Avatar
variant="rounded"
src={season.logoUrl || getAsset('FIRST-Logo.svg')}
Expand All @@ -84,12 +90,13 @@ export default async function CurrentSeasonWidget() {
<Typography
variant="overline"
sx={{
color: "text.secondary",
color: 'text.secondary',
lineHeight: 1,
fontSize: '0.875rem',
fontWeight: 600,
letterSpacing: 0.5
}}>
}}
>
{t('current-season')}
</Typography>

Expand Down
14 changes: 8 additions & 6 deletions apps/admin/src/app/[locale]/(dashboard)/components/widgets/number-widget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@ export default function NumberWidget({ value, description, icon }: NumberWidgetP
<CardContent sx={{ height: '100%', display: 'flex', alignItems: 'center' }}>
<Box
sx={{
display: "flex",
alignItems: "center",
display: 'flex',
alignItems: 'center',
gap: 3,
width: "100%"
}}>
width: '100%'
}}
>
{icon && (
<Box
sx={{
Expand Down Expand Up @@ -66,12 +67,13 @@ export default function NumberWidget({ value, description, icon }: NumberWidgetP
<Typography
variant="body1"
sx={{
color: "text.secondary",
color: 'text.secondary',
fontSize: '0.95rem',
lineHeight: 1.3,
wordBreak: 'break-word',
fontWeight: 500
}}>
}}
>
{description}
</Typography>
</Stack>
Expand Down
21 changes: 12 additions & 9 deletions ...admin/src/app/[locale]/(dashboard)/components/widgets/upcoming-events/event-list-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ export default function EventListItem({ event }: EventListItemProps) {
>
<Box
sx={{
display: "flex",
alignItems: "center",
width: "100%",
display: 'flex',
alignItems: 'center',
width: '100%',
gap: 2
}}>
}}
>
<Stack spacing={0.5} sx={{ flex: 1, minWidth: 0 }}>
<Typography
variant="body2"
Expand All @@ -48,25 +49,27 @@ export default function EventListItem({ event }: EventListItemProps) {
<Typography
variant="caption"
sx={{
color: "text.secondary",
color: 'text.secondary',
lineHeight: 1.2,
wordBreak: 'break-word',
fontSize: '0.8rem'
}}>
}}
>
{event.location}
</Typography>
</Stack>

<Box
sx={{
display: "flex",
alignItems: "center",
display: 'flex',
alignItems: 'center',
gap: 1,
bgcolor: 'action.hover',
borderRadius: 1.5,
px: 1.5,
py: 0.75
}}>
}}
>
<CalendarToday
sx={{
fontSize: 16,
Expand Down
5 changes: 3 additions & 2 deletions ...admin/src/app/[locale]/(dashboard)/components/widgets/upcoming-events/upcoming-events.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ export default async function UpcomingEventsWidget() {
<Typography
variant="body2"
sx={{
color: "text.secondary",
color: 'text.secondary',
fontWeight: 500
}}>
}}
>
{t('no-events')}
</Typography>
</Box>
Expand Down
5 changes: 3 additions & 2 deletions apps/admin/src/app/[locale]/(dashboard)/dev/graphql/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ export default function GraphQLSchemaPage() {
<Typography
variant="body2"
sx={{
color: "text.secondary",
color: 'text.secondary',
mt: 0.5
}}>
}}
>
Explore and interact with the GraphQL schema for the LEMS application.
</Typography>
</Box>
Expand Down
9 changes: 6 additions & 3 deletions apps/admin/src/app/[locale]/(dashboard)/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ export default function Error({

return (
<Box sx={{ py: 6 }}>
<Stack spacing={2} sx={{
alignItems: "flex-start"
}}>
<Stack
spacing={2}
sx={{
alignItems: 'flex-start'
}}
>
<Typography variant="h4">Something went wrong</Typography>
<Alert severity="error">{error.message || 'Unexpected error'}</Alert>
<Button variant="outlined" onClick={reset}>
Expand Down
15 changes: 10 additions & 5 deletions apps/admin/src/app/[locale]/(dashboard)/events/[slug]/awards/components/award-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,13 @@ export function AwardItem({ award, index }: AwardItemProps) {
}
}}
>
<Stack direction="row" spacing={2} sx={{
alignItems: "center"
}}>
<Stack
direction="row"
spacing={2}
sx={{
alignItems: 'center'
}}
>
<Box
{...provided.dragHandleProps}
sx={{
Expand All @@ -91,9 +95,10 @@ export function AwardItem({ award, index }: AwardItemProps) {
<Typography
variant="body2"
sx={{
color: "text.secondary",
color: 'text.secondary',
overflow: 'hidden'
}}>
}}
>
{getDescription(award)}
</Typography>
</Box>
Expand Down
45 changes: 30 additions & 15 deletions apps/admin/src/app/[locale]/(dashboard)/events/[slug]/awards/components/awards-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,23 +52,31 @@ export const AwardsHeader = () => {
<Stack
direction="row"
sx={{
justifyContent: "space-between",
alignItems: "center"
}}>
justifyContent: 'space-between',
alignItems: 'center'
}}
>
<Box>
<Typography variant="h5" sx={{ fontWeight: 600, mb: 1 }}>
{t('title')}
</Typography>
<Typography variant="body2" sx={{
color: "text.secondary"
}}>
<Typography
variant="body2"
sx={{
color: 'text.secondary'
}}
>
{t('subtitle')}
</Typography>
</Box>

<Stack direction="row" spacing={2} sx={{
alignItems: "center"
}}>
<Stack
direction="row"
spacing={2}
sx={{
alignItems: 'center'
}}
>
<Tooltip
title={isNew ? t('status.new-awards-tooltip') : t('status.existing-awards-tooltip')}
arrow
Expand Down Expand Up @@ -124,13 +132,20 @@ export const AwardsHeader = () => {
border: `1px solid ${alpha(theme.palette.warning.main, 0.3)}`
}}
>
<Stack direction="row" spacing={1} sx={{
alignItems: "center"
}}>
<Stack
direction="row"
spacing={1}
sx={{
alignItems: 'center'
}}
>
<Chip label={t('unsaved-changes')} color="warning" variant="outlined" size="small" />
<Typography variant="body2" sx={{
color: "text.secondary"
}}>
<Typography
variant="body2"
sx={{
color: 'text.secondary'
}}
>
{t('unsaved-warning')}
</Typography>
</Stack>
Expand Down
Loading
Loading