Skip to content

ci: wire integration baseline + env-var defaults.conf resolution#512

Closed
spreston8 wants to merge 1 commit into
rust/stagingfrom
ci/integration-baseline-on-staging
Closed

ci: wire integration baseline + env-var defaults.conf resolution#512
spreston8 wants to merge 1 commit into
rust/stagingfrom
ci/integration-baseline-on-staging

Conversation

@spreston8

Copy link
Copy Markdown
Collaborator

Summary

Updates the integration-tests CI step on `rust/staging` to:

  1. Track system-integration's `refactor/integration-test-framework` branch tip instead of the stale pinned commit `2ace29f4` (from before the v2 test framework refactor).
  2. Run the canonical baseline that's the source of truth in `system-integration/docs/TODO.md` §1: walk `tests/{shared,custom,standalone}/` with the current deselect list (7 entries), xdist `-n auto --dist=loadgroup`, `--instafail --maxfail=10`.
  3. Set `F1R3FLY_NODE_DEFAULTS_CONF` so `NodeConf.resolve()` finds the node's `defaults.conf` at the CI checkout location, where f1r3node is the outer checkout and system-integration is nested under it. (Without this, ~12 tests/arch ERROR at setup with `FileNotFoundError: services/f1r3node-rust/node/...defaults.conf`. The system-integration side has a corresponding three-tier resolver in `integration-tests/test/infra/config.py`: env-var override → local-dev fallback → CI fallback.)

Why this PR, not edits on #507 / #508

#507 and #508 already had similar CI-wiring commits applied directly. But the right place to fix this is `rust/staging` — once this lands, both PRs (and any future PR off staging) inherit the fix on rebase, and the duplicated wiring commits can be dropped.

Pairs with

  • system-integration commit `bad7fdc` on `refactor/integration-test-framework` — introduces `resolve_node_defaults_conf()` with env-var + 2 fallback paths.

Test plan

  • CI on this PR runs green against `rust/staging` (`bf6a03d2`) with no infra ERRORs.
  • Verify the `F1R3FLY_NODE_DEFAULTS_CONF` env var appears in CI logs as `/opt/actions-runner/_work/f1r3node/f1r3node/node/src/main/resources/defaults.conf` (or equivalent runner path).
  • Deselected tests stay deselected (matches TODO.md §1).
  • No regression vs. the 91/0 subprocess baseline / 93/0-target Docker baseline.

Co-Authored-By: Claude noreply@anthropic.com

Track system-integration's refactor/integration-test-framework branch tip
(was pinned to 2ace29f4) and run the canonical baseline:
- walk tests/{shared,custom,standalone}/
- apply current deselect list (7 entries: load, slow-deploy, asymmetric
  finalization, ft-convergence, bonding-validators, joiner-self-proposes
  WIP, observer-lfs-sync WIP)
- xdist -n auto with loadgroup, instafail, maxfail=10

Set F1R3FLY_NODE_DEFAULTS_CONF so NodeConf.resolve() finds the node's
defaults.conf at the CI checkout location (where f1r3node is the outer
checkout and system-integration is nested under it).
spreston8 added a commit that referenced this pull request May 11, 2026
Targets the new ephemeral runner label set. Reuses the canonical
baseline command + deselect list from PR #512 (TODO.md §1). Runs
against the staging Docker image pre-pulled into the baked golden
image.

Trigger 10x via workflow_dispatch for parallel soak runs;
--maxfail=1 surfaces the first failure fast per run.
spreston8 added a commit that referenced this pull request May 11, 2026
Targets the new ephemeral runner label set. Reuses the canonical
baseline command + deselect list from PR #512 (TODO.md §1). Runs
against the staging Docker image pre-pulled into the baked golden
image.

Trigger 10x via workflow_dispatch for parallel soak runs;
--maxfail=1 surfaces the first failure fast per run.
@spreston8
spreston8 marked this pull request as draft May 13, 2026 00:07
@spreston8

Copy link
Copy Markdown
Collaborator Author

Superseded by #516. The env-var resolver for defaults.conf that this PR introduced has already landed on system-integration's `refactor/integration-test-framework` branch (commit bad7fdc) and is used by #516 today. The workflow piece is replaced by #516's ephemeral 20-job dual-provider matrix (docker + subprocess), which is the longer-term direction.

Closing in favor of #516.

Co-Authored-By: Claude noreply@anthropic.com

@spreston8 spreston8 closed this May 13, 2026
@spreston8
spreston8 deleted the ci/integration-baseline-on-staging branch May 13, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant