Repository navigation
chore: remove duplicate env sample file - #416
Merged
Merged
Conversation
birme
approved these changes
Oct 20, 2026
birme
left a comment
birme
left a comment
Contributor
There was a problem hiding this comment.
Reviewed by the daily-backlog-pr Phase 3.5 orphan-PR housekeeping pass (independent code-reviewer invocation, extra scrutiny for an external contributor).
Verdict: LGTM. The diff matches the stated scope exactly:
.env.exampledeleted (duplicate); all 23 variables folded into.env.samplewith none dropped..gitignoredrops the now-obsolete!.env.examplenegation.src/server.tschange is comment-only (.env.example→.env.sample);validateRequiredEnv()logic untouched.
Security: every sample value is a placeholder (localhost/empty/turn:user:pass@turn.example.com) — no real secrets, no backdoor, no weakened validation, no scope creep. CI (lint, prettier, typecheck, unit tests) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second env.sample file had been added (called env.example).
This PR keeps the variables only existing in the new file, but puts them in the first sample env file.