Repository navigation
Conversation
…group A WHIP and a WHEP connection with the same username represent the same party, e.g. a site gateway bridging a hardware talkback system. Setting an SMB neighbour group named after the username makes SMB skip forwarding audio between them, so the party does not get its own audio back (mix-minus) and no feedback loop is created through the gateway. Only applies to WHIP and WHEP endpoints; browser sessions are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
srperens
marked this pull request as draft
October 14, 2026 07:51
Contributor
|
This PR looks like part of the multi-repo video-support dependency stack together with:
Holding off on automated review/merge here — this needs a human (or the relevant implementation agent) to assess the whole stack together, not a per-PR pass. (This PR is also a draft.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a site gateway (e.g. Strom bridging a hardware talkback system) joins a line with both a WHIP (send) and a WHEP (receive) connection, the WHEP stream contains the site's own WHIP audio. The site hears itself back, and through the hardware system this becomes a feedback loop. We need mix-minus per party.
What
WHIP and WHEP endpoints are now placed in an SMB neighbour group named after the username:
whipwhep:<username>. SMB never forwards audio between endpoints that share a neighbour group (seeEngineMixerAudio.cppin SymphonyMediaBridge), so a WHIP and WHEP pair with the same username works as the same party. No extra configuration is needed.neighboursto theSmbEndpointDescriptionschema.Note: the username is now the identity of the party. Two different parties that use the same username on the same line will not hear each other.
Background: SMB neighbours
Neighbour groups in SMB are originally meant for acoustic echo: when several participants sit in the same physical room, their microphones pick up each other's speakers. SMB does not route audio between endpoints in the same neighbour group, which avoids acoustic feedback in the room.
Here we use the same mechanism for a different purpose: a WHIP and a WHEP endpoint with the same username are the same party, so they are put in the same group and the party never gets its own audio back.
Testing
🤖 Generated with Claude Code