Match session takeover on transport identifier only#73
Conversation
ReplaceExistingSessionIfPresent matched on UniqueClientIdentifier OR AuthKey. Because AuthKey is persisted in ModSettings and shared across all clients launched from the same install, two local clients connecting to the same server caused the second connection to displace the first. Restrict the match to UniqueClientIdentifier, leaving the legitimate same-transport reconnect path intact.
|
Thank you for putting this pull request together. While I understand this was introduced to solve a specific local-testing convenience issue -- specifically, allowing multiple local client instances launched from the exact same installation folder to connect without displacing one another; we cannot merge this change in its current form. Removing the
|
|
Agreed, thanks for reviewing. |
Because AuthKey is shared across all clients launched from the same install, two local clients connecting to the same server caused the second connection to disconnect the first. This makes locally testing dev builds difficult. My mistake from a previous PR.