Skip to content

Add support for non-uniform distributions of elements#694

Closed
MartinKarp wants to merge 1 commit intodevelopfrom
feature/variable_datadist
Closed

Add support for non-uniform distributions of elements#694
MartinKarp wants to merge 1 commit intodevelopfrom
feature/variable_datadist

Conversation

@MartinKarp
Copy link
Collaborator

@MartinKarp MartinKarp commented Oct 28, 2022

Adds an environment variable rank_weight that can be set in order to weight the distribution of elements across ranks.

@timofeymukha
Copy link
Collaborator

Did we forget to review this?

@njansson
Copy link
Collaborator

njansson commented Feb 1, 2024

Since everything is OO, I would argue that it should be solve by a new distribution type, and not by adding optional arguments

@timfelle
Copy link
Collaborator

@njansson, @timofeymukha What is the plan here?

@njansson
Copy link
Collaborator

@njansson, @timofeymukha What is the plan here?

I would say we can close it for now (and reopen when needed).

This was mainly for a project specific use case

@timofeymukha
Copy link
Collaborator

Yeah, if nobody bothered with it since Oct 2022, I think we can close it for now.

@timfelle timfelle closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants