Skip to content

added a zero pressure gradient tripped turbulent boundary layer example#2229

Open
Mr-2c wants to merge 2 commits intodevelopfrom
example/ZPG_TBLzip
Open

added a zero pressure gradient tripped turbulent boundary layer example#2229
Mr-2c wants to merge 2 commits intodevelopfrom
example/ZPG_TBLzip

Conversation

@Mr-2c
Copy link
Collaborator

@Mr-2c Mr-2c commented Dec 10, 2025

the mesh is a bit large, so let me know if it is appropriate as an example. also the trip.f90 is basically from @vbaconnet from a code from @MartinKarp based on the original code from @adampep, so not sure how the acknowledgment works here, but I added all their names to the trip.f90 file

@@ -0,0 +1,30 @@
# Flow
This example is a zero pressure gradient (ZPG) turbulent boundary layer (TBL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mr-2c just two initial things:

  • Remove the .log
  • Remove the mesh and instead add the genmeshbox command to genereate it to the readme. If you are using a file to prescribe the element size distribution, add those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the mesh is huge, can't we store both the compressed nmsh and the genmeshbox command?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mr-2c just two initial things:

  • Remove the .log

I somehow wanted to have the .log so the users can see how the mesh was created. but I can remove it if it is inconstant with our guidelines

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can easily just add that to the readme as well. Something like:

To generate the mesh use some command
The expected output should be

xmin, xmax, Nel, periodic:    0.000000   162.500000   96 F
ymin, ymax, Nel, periodic:    0.000000    65.000000   64 F
zmin, zmax, Nel, periodic:    0.000000    78.000000  112 T

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, will do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the mesh is huge, can't we store both the compressed nmsh and the genmeshbox command?

I am adding the genmeshbox command to the readme file. is that sufficient?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the mesh is huge, can't we store both the compressed nmsh and the genmeshbox command?

the full mesh is 1.8GB before compression and 253MB after compression, so I think it cannot be included. the current smaller one just let me know whether you want to keep to remove, I am fine either way...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to just remove the mesh and let the user generate it themselves. Especially if you need to compress the mesh to include it.

end subroutine user_mesh_scale

!=============================================================================!
! this makes a "fake" sine-shaped profile for the inflow as a proxy for the Blasius profile
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot use the built-in Blasius?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the mesh is axis aligned, built-in "should work"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a comment to emphasize this but will somehow want to make as few changes as possible now, unless you think it is important

Comment on lines +30 to +31
// "type": "field",
// "file_name": "field0.f00008"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we clean this up for the final state of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Todo

Development

Successfully merging this pull request may close these issues.

4 participants