Multiphase over integration#2217
Multiphase over integration#2217gloopydoop wants to merge 4 commits intotuan/case/lid-multiphasefrom
Conversation
| "numerics": { | ||
| "time_order": 3, | ||
| "polynomial_order": 7, | ||
| "dealias": true |
There was a problem hiding this comment.
perhaps it makes more sense to place it here in the JSON
|
why is it slower by 30 times? I would probably expect it's 10 times when assenble the total forcing term, and approximately the same time for the pressure and velocity equation (so in total much smaller than 30 times). |
|
I am wondering in this regard whether implementing some type of 2/3 rule instead could be beneficial, so that one does not need to dealias many individual terms...? Or is there a drawback on doing that? |
|
Can we merge this in, so it doesn't hang around in the PR list :)? |
Sounds like a good plan |
Bump this thread, should we get it in? |
Finally a commit to multiphase!
In this PR I add a way of performing over integration (dealiasing) on the term
If one considers the test function too, this is 4 polynomials multiplied together, so it's not a 3/2 rules, it's a 4/2=2 rule.
You should be able to enable it with
"dealias_normal": trueunderscalar.There's also a little profiler wrapping each computations, I'm seeing (from small tests)