Video thumbnail#166
Open
Quffik wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Replaced the nested
if-elsewidget structure with a clean ternary conditional expression to renderMxcImagecorrectly, fixed the fallbackBlurHashaspect ratio rendering formula, grouped the duration and file size inside a single styled corner badge, and updated the action button to a custom translucentIconButton.filledTonal.Why: The fallback blurred layout suffered from a broken height computation, causing layout distortion. Additionally, combining metadata overlay information saves vertical bubble space and provides a polished design matching modern chat interfaces.
How:
BlurHashheight definition frombubbleWidth * aspectRatiotobubbleWidth / aspectRatio.sizeInt?.sizeStringinto a unified string separated by a bullet (•), placed inside a singlePositionedcontainer with custom padding and background transparency.IconButton.filledTonalusing a hardcodedIcons.play_arrow_outlinediconPull Request has been tested on: