Repository navigation
Release v0.7.1: Spanish store listing - #127
Merged
Merged
Conversation
Move the manifest name, description, and shortcut description into _locales (en default, es) so the Chrome Web Store accepts a Spanish listing and Spanish-language Chrome shows the Spanish strings. The package smoke check now fails on unresolved __MSG_ placeholders or over-length store strings in any locale. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_locales/en(default) and_locales/es. The Chrome Web Store only offers a Spanish listing once the package includes Spanish strings. About a third of current users are in Argentina or browse in Spanish.npm run smoke:packagenow fails if any__MSG_*__placeholder is missing from a locale, or if a locale's name or summary is over the store limits (75 and 132 characters).Test plan
--max-warnings=0),audit:prod,audit:dev,test:coverage(613/613),npm run packagedistin headless Edge:--lang=es,chrome.i18nreturns the Spanish name, summary and shortcut text.--lang=en-GB, it falls back to English.🤖 Generated with Claude Code