Repository navigation
fix(core): clear settled manage-request timers - #357
Conversation
|
Thanks for this, and for the test discipline: I checked out your branch and all six regression cases fail on the previous code and pass with the fix, the timer handle is always assigned before the race can settle, and the timeout path itself (including forgetting a dead pairing) is untouched. Merging now. One note for the record: the six threshold test files also fail in a fresh checkout, but that is unrelated to this change (the wasm module is built by |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
Why
Settled manage requests leave their timeout callbacks alive. Those timers can keep Node running until the request deadline, even after the session has closed.
Changes
Verification