Repository navigation
fix(core): keep a device's newest advert when an older one arrives later - #356
Merged
Merged
Conversation
A session applied gossiped adverts in arrival order, so an older advert forwarded by a hub or gateway after a newer one rolled the device back in the session directory. A device whose two versions kept arriving interleaved alternated between them on every directory event. The directory now keeps the advert with the greater signed snapshot-seconds, the same rule the relay hub applies when registering a device.
Mearman
marked this pull request as ready for review
October 19, 2026 12:33
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session's directory takes whichever advert for a device arrives last. A hub or relay that forwards adverts it holds from earlier can deliver an older one after a newer one, which rolled the device back, and a device whose versions kept arriving interleaved alternated between them on every directory event. In agent-comms this made every hub directory event look like new proofs for the same devices and kept a bridge's CPU high.
The directory now keeps the advert with the greater signed snapshot-seconds, matching the rule the relay hub already applies to registrations. The threshold-* suites fail in this checkout only because wasm-dist is not built.