Repository navigation
feat(web-console): replicate notice logs through a hub - #321
Merged
Merged
Conversation
Mearman
marked this pull request as ready for review
October 1, 2026 09:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Mearman
enabled auto-merge (rebase)
October 1, 2026 09:58
Mearman
force-pushed
the
feat/replicate-notices
branch
from
October 1, 2026 10:14
bce057d to
8974fe0
Compare
Mearman
marked this pull request as draft
October 1, 2026 10:14
auto-merge was automatically disabled
October 1, 2026 10:14
Pull request was converted to draft
Mearman
marked this pull request as ready for review
October 1, 2026 10:14
Mearman
enabled auto-merge (rebase)
October 1, 2026 13:03
createMeshSession takes the same optional frame hook acceptMeshSession has, so a caller can receive the core/data replies a hub sends and notice a fresh connection after a reconnect. sendRoomRekey needs only a session's sendManageRequest.
…ticipant root policy A DM member's token is rooted at the other participant, so the strict root rule rejected the member's own notices when it read its own log. Notices read from another device still must be rooted at the reader.
One notice wiring now serves the whole console. Own logs are announced to a hub or peer when it connects and after each post, and the logs of a conversation's peers are requested from it, so a notice posted while the peer was offline is read from the hub after the peer reconnects. The DM first epoch and notice posting work over a hub route as well as a direct one, and the first epoch key is sent again until the peer has taken it, so a peer that was offline or had no token yet still receives it. A message from a peer triggers a pull of its log, notices of restored conversations are read on load, and a hub connection is one stable object so closing it drops the conversations' routes through it.
Two consoles connect to a hub with a mailbox directory and no direct route; one closes, the other posts, and the first reads both notices after reconnecting on the same storage.
Mearman
force-pushed
the
feat/replicate-notices
branch
from
October 1, 2026 13:05
8974fe0 to
fc45abc
Compare
Member
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage B of #274: notice logs are exchanged with every connected route (a hub with a mailbox as well as a direct peer), so a notice posted while the peer was offline is read after the peer reconnects. Also fixes a DM's own-notice verification and redelivers the first epoch key until acknowledged. Closes #274. Live announcement over a hub is tracked in #322.