Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 30, 2026
Closed
Mearman
force-pushed
the
feat/console-naming
branch
from
October 1, 2026 08:50
f231150 to
1260305
Compare
A petname is this viewer's own label for a device, kept in the console's own storage and never gossiped. A self display name is read from the agent/self entry of a verified advert, the key agent-comms and the public hub's advert policy already carry, and this console publishes its own through the same entry. The convention is implemented once in peer-names.ts and reached through a context by the conversation list, the connection directory and the discovered-peers table.
…trip control characters from it PeerName and the conversation labels rendered only the stranger-chosen name, so two peers claiming one name could not be told apart. cleanName now drops control and bidirectional formatting characters and truncates by code point.
… and surface publish failures
…d surface name storage failures
…nd trim a name after the length cut A self name is shown in italics under a 'calls itself' marker and flagged when it equals a petname the viewer holds for any device. cleanName trims after truncating so a cut after a space leaves no trailing space, and the Save button compares the draft with its cleaned form.
…es context ConnectionPanel now reads peer names through PeerNamesProvider, so the local-network explanation test, written before names existed, has to mount the panel the way the app does.
Mearman
force-pushed
the
feat/console-naming
branch
from
October 1, 2026 08:58
1260305 to
f659e79
Compare
Mearman
enabled auto-merge (rebase)
October 1, 2026 08:58
Member
Author
|
These commits landed in main as part of #316, which carried the whole console stack as one branch so it needed a single CI cycle against a moving main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console's conversation list, connection directory and discovered-peers table now name a peer by the same three-tier convention instead of a raw device-id: a petname this viewer gave the device, else the display name the device signed about itself, else a short id (the leading 12 hex characters, with a copy button for the full id). The convention lives in
peer-names.tsand reaches every surface throughPeerNamesContext, so the three tables cannot drift apart.Petnames are stored under
petname/<device-id>in the console's own IndexedDB storage (name-store.ts) and never leave it. A self display name is read from theagent/selfextension of a verified peer-advert, which the advert signature already covers. I used that key rather than inventing one because agent-comms publishes its agent name under it and the public hub's advert policy carries exactly that shape (nameplusharness), so a console name reaches peers through that hub and agent-comms names show up here. The console publishes its own name (set in the new "Your display name" field) by re-sending its self-advert with that extension once a session is connected and whenever the name changes. Names from peers are trimmed and bounded, since they come from strangers.Not done: proper names (wire-mesh handles) are not implemented in the protocol yet, so they are not a tier here.
Fixes #295