Repository navigation
fix: remove the staged release tag and bump the package version - #6
Merged
Merged
Conversation
The core tags and pushes a release straight after prepare, so every staging run left a tag on a commit that is not on the base branch, and the next run failed with "tag already exists". The publish step now removes the tag it was handed, and verifyRelease clears one left by an earlier run unless the base branch contains it.
Nothing in the release configuration wrote the next version into package.json, so a merged release pull request carried only the changelog and the publish job would have read the placeholder version. The npm plugin runs with publishing off so prepare writes the version and the staging plugin commits it.
Member
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semantic-release tags and pushes right after prepare, so each staging run tagged an unmerged commit and the next one failed on the existing tag (the dry-run attempt in the previous PR does not work: plugins receive a deep clone of the options, so the flag never reaches the core). The plugin now deletes that tag in its publish step and clears a stale one in verifyRelease unless the base branch contains it. Separately, nothing bumped package.json, so the release PR carried only CHANGELOG.md and the publish job would have published the placeholder version; @semantic-release/npm runs with npmPublish off to write it.