Repository navigation
fix: let the release pull request receive its required checks - #4
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
GitHub skips push and pull_request workflows for a head commit whose message carries its skip-workflow token, so the default release commit message kept the staged pull request from ever reporting a required check. The default no longer carries the token. A release branch pushed with GITHUB_TOKEN also starts no workflow. This repository's own staging job now checks out with a deploy key so the push runs CI, CI runs on release/** pushes, and the job skips the push that lands the merged release commit.
Mearman
force-pushed
the
ci/stage-release-with-deploy-key
branch
from
October 10, 2026 14:47
56df96a to
00e97d0
Compare
Member
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release commit's default message carried [skip ci], which makes GitHub skip push and pull_request workflows for the head commit, so the staged release PR could never report Required Checks. The GITHUB_TOKEN push has the same effect on its own. This drops [skip ci] from the default, pushes the release branch from this repo's staging job with a deploy key (secret RELEASE_DEPLOY_KEY, read-write deploy key on the repo), runs CI on release/** pushes, and stops the staging job running on the merged release commit itself.
Verification after merge: the staging run re-pushes release/1.0.0 and the PR should show Required Checks.