Skip to content

feat: mark labelled drafts ready for review once a required check passes - #2

Merged
Mearman merged 1 commit into
mainfrom
feat/ready-when-green
Oct 10, 2026
Merged

Mearman merged 1 commit into
mainfrom
feat/ready-when-green

Conversation

@Mearman

@Mearman Mearman commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Adds the action: merge-when with then: ready and the conditions fixed to the opt-in label (default automerge) and the named check, with merge-when-green's inputs less merge-method, ssh-key and update-behind, which then: ready rejects. The README documents running it on workflow_run completed beside merge-when-green, whose ready_for_review trigger merges what this marks ready, and that CI has to run on drafts.

The repository runs both on itself (ready-when-green.yml and merge-when-green.yml) with the organisation's GitHub App, and a new Action CI job runs the composite action from the checkout. That job passes against the current merge-when v1 too, since an unknown then input is only a warning and no pull request is at the run's commit, so the end-to-end proof is a real draft here once ExaDev/merge-when#8 is released.

A thin wrapper of merge-when with then: ready and the conditions fixed to the opt-in label
and the named check, mirroring merge-when-green's inputs less the merge-only ones. The
README covers running it beside merge-when-green, whose ready_for_review trigger merges what
this marks ready, and that CI has to run on drafts.

This repository runs both on itself with the organisation's GitHub App, and a CI job runs
the composite action from the checkout through the published merge-when.
@Mearman
Mearman marked this pull request as ready for review October 10, 2026 08:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-10T08:53:30.855951Z 148d755 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Mearman
Mearman merged commit eebb2e8 into main Oct 10, 2026
18 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Mearman
Mearman deleted the feat/ready-when-green branch October 10, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant