Repository navigation
fix: report dropped elements in projections and validate overlays against a model - #11
Merged
Merged
Conversation
toFlowchart and toSwimlane silently left out state elements and history pseudo-states, and toStateMachine left out fork, join and history pseudo-states while still emitting transitions that pointed at them. A sequence scenario step touching an element with no actor vanished without trace. Add the unrepresented-elements loss kind, carrying each element with what it was, the notation that cannot draw it and the transitions left out because of it, and the skipped-steps loss kind for scenario steps that draw no message. The state machine no longer emits a transition whose target is not one of its states. Decisions folded into guards remain by design and are not a loss.
parseOverlay is model-independent, so an overlay naming an element the model never declared loaded without complaint and silently described nothing. Add validateOverlay(model, overlay), which returns an overlay-unknown-element issue naming each such identifier, in the package's existing Issue shape. parseOverlay is unchanged.
Mearman
marked this pull request as ready for review
October 10, 2026 09:34
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two defects found reviewing the merged schema and projection packages.
Projections dropped elements without saying so.
toFlowchartandtoSwimlaneleft outstateelements andhistorypseudo-states, andtoStateMachineleft outfork,joinandhistorypseudo-states while still emitting transitions that pointed at them. A newunrepresented-elementsloss reports each element with what it was, the notation that cannot draw it and the transitions left out because of it. A sequence scenario step touching an element with no actor was also skipped silently; it is now askipped-stepsloss. Decisions folded into guards stay a design choice, not a loss. The state machine no longer emits a transition whose target is not one of its states.parseOverlayaccepted an overlay naming an element the model does not declare.validateOverlay(model, overlay)returns anoverlay-unknown-elementissue per unknown id;parseOverlaystays model-independent.