Repository navigation
fix(frontdoor): start a watchdog replacement under the launcher's start lock - #513
Merged
Merged
Conversation
…rt lock A launcher that found the stalled door's pid dead in state.json spawned a door of its own while the watchdog's replacement was still booting, because the respawn never took the start lock the launcher's ensure checks. Under load the launcher's door took long enough to start that the replacement had already bound the sticky ports and was serving; the late door found them held, moved off them, and then superseded the healthy door, stranding every session launched against the old addresses. The respawn now takes the same lock, naming the replacement as its holder, so a launch that sees the dead pid waits for the replacement instead of starting a second door. A live lock holder that already has a door starting stops the respawn, and a dead holder's lock is cleared as the launcher clears it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(frontdoor): start a watchdog replacement under the launcher's start lock
A launcher that found the stalled door's pid dead in state.json spawned a
door of its own while the watchdog's replacement was still booting, because
the respawn never took the start lock the launcher's ensure checks. Under
load the launcher's door took long enough to start that the replacement had
already bound the sticky ports and was serving; the late door found them
held, moved off them, and then superseded the healthy door, stranding every
session launched against the old addresses.
The respawn now takes the same lock, naming the replacement as its holder,
so a launch that sees the dead pid waits for the replacement instead of
starting a second door. A live lock holder that already has a door starting
stops the respawn, and a dead holder's lock is cleared as the launcher
clears it.