Repository navigation
fix(frontdoor): recognise a translator's model choice from the request and response bodies - #511
Merged
Merged
Conversation
…t and response bodies The internal response header that carried a route's model choice back through the headroom hop reached the recording pipeline only when the daemon relayed the response head verbatim, which its transformed streaming paths do not: they build their own SSE head, so a compressed main turn lost the choice a translator noted behind the hop while small untransformed requests kept it. The choice is now recognised where the record is built, from two facts the recording pipeline sees itself: the model name the request's own body carried, which the hop reads out when it collects the body to forward (the same read that already yields the conversation thread), and the model the response body was served under, which the body scan already records. When the two names differ and no routing layer noted a choice outright, the record carries the requested name beside the served model, naming the serving provider. No daemon behaviour is depended on, and the superseded header channel is gone.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(frontdoor): recognise a translator's model choice from the request and response bodies
The internal response header that carried a route's model choice back
through the headroom hop reached the recording pipeline only when the
daemon relayed the response head verbatim, which its transformed
streaming paths do not: they build their own SSE head, so a compressed
main turn lost the choice a translator noted behind the hop while small
untransformed requests kept it.
The choice is now recognised where the record is built, from two facts
the recording pipeline sees itself: the model name the request's own
body carried, which the hop reads out when it collects the body to
forward (the same read that already yields the conversation thread), and
the model the response body was served under, which the body scan
already records. When the two names differ and no routing layer noted a
choice outright, the record carries the requested name beside the served
model, naming the serving provider. No daemon behaviour is depended on,
and the superseded header channel is gone.