Repository navigation
fix(frontdoor): always leave a replacement door behind a watchdog kill - #509
Merged
Merged
Conversation
A watchdog kill used to start a replacement only when the door had already served past the idle-shutdown window: a young door killed by a stall the machine caused (observed in production, an overloaded host stalling the loop shortly after the door bound) left nothing behind, and every live session then saw connection refused until some later launch happened to start a door. The serving-time gate is replaced by a bounded respawn chain. Every stall now starts a replacement, and each replacement carries its generation in an env var the next door's watchdog reads, so the chain stops after a fixed number of consecutive replacements: a stall that has recurred through that many doors in a row with none of them serving is the machine's, and the next launch's ensure is what starts the door after that, exactly as before.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(frontdoor): always leave a replacement door behind a watchdog kill
A watchdog kill used to start a replacement only when the door had
already served past the idle-shutdown window: a young door killed by a
stall the machine caused (observed in production, an overloaded host
stalling the loop shortly after the door bound) left nothing behind, and
every live session then saw connection refused until some later launch
happened to start a door.
The serving-time gate is replaced by a bounded respawn chain. Every
stall now starts a replacement, and each replacement carries its
generation in an env var the next door's watchdog reads, so the chain
stops after a fixed number of consecutive replacements: a stall that has
recurred through that many doors in a row with none of them serving is
the machine's, and the next launch's ensure is what starts the door
after that, exactly as before.