Repository navigation
ci: drop install and cache work the CI tasks never use - #508
Merged
Merged
Conversation
The CI jobs' cost is dominated by setup, not the tasks themselves, and three pieces of that setup buy nothing: The build jobs persisted and restored the whole dist tree as their Turbo cache entry. Moving that entry through the runner cache costs more than the build it would skip, a restored entry was routinely a miss anyway (the PR's own source change is what invalidated it), and every such write evicts pnpm-store entries the other tasks actually restore from. The build jobs now run uncached through Turbo in CI; local `turbo run _build` keeps its cache. `pnpm install` in CI now passes --ignore-scripts: the package's prepare script runs husky and an esbuild bundle of the CLI, and no CI task consumes that bundle (lint, typecheck, test and knip read the sources; the build and publish jobs bundle explicitly). Runners have no use for the git hooks. The audit job installs nothing: pnpm audit reads the lockfile alone. The composite action gains `install` and `cache-turbo` inputs, both defaulting to the previous behaviour, so only the jobs named above change what they do.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: drop install and cache work the CI tasks never use
The CI jobs' cost is dominated by setup, not the tasks themselves, and
three pieces of that setup buy nothing:
The build jobs persisted and restored the whole dist tree as their
Turbo cache entry. Moving that entry through the runner cache costs
more than the build it would skip, a restored entry was routinely a
miss anyway (the PR's own source change is what invalidated it), and
every such write evicts pnpm-store entries the other tasks actually
restore from. The build jobs now run uncached through Turbo in CI;
local
turbo run _buildkeeps its cache.pnpm installin CI now passes --ignore-scripts: the package'sprepare script runs husky and an esbuild bundle of the CLI, and no CI
task consumes that bundle (lint, typecheck, test and knip read the
sources; the build and publish jobs bundle explicitly). Runners have
no use for the git hooks.
The audit job installs nothing: pnpm audit reads the lockfile alone.
The composite action gains
installandcache-turboinputs, bothdefaulting to the previous behaviour, so only the jobs named above
change what they do.