Repository navigation
fix(frontdoor): log every exit and replace a door its watchdog ended - #444
Merged
Merged
Conversation
A door that left silently looked, from outside, like one that was never there: SIGTERM, SIGINT and the watchdog's SIGKILL wrote nothing to the log, so the next launch found a dead door with no explanation. Each exit path now writes its reason to the log first. When the watchdog ends a stalled door that had served at least the idle shutdown window, it also starts a replacement that waits for the stalled pid to exit before binding the sticky ports, so sessions are not left on a refused port until the next launch. A door that stalls sooner than that is left to the next launch's ensure, so a deterministic stall cannot loop.
Mearman
marked this pull request as ready for review
October 14, 2026 06:47
Member
Author
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A door exited at an unknown time with nothing in the log, leaving sessions on a refused port until a manual start. Every exit path now logs its reason, and a watchdog stall on a door that had served long enough starts a replacement that waits for the stalled pid before binding. Covered by watchdog and supervisor tests; typecheck, lint and the full suite pass.