Repository navigation
feat(doctor): probe both front door listeners instead of trusting the supervisor pid - #432
Conversation
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
78f705c to
a5b8b23
Compare
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
… supervisor pid A door whose event loop is blocked is alive and accepts nothing, and doctor and frontdoor status reported one healthy supervisor while every connection to both listeners timed out. Both now ask the listeners themselves: a TLS handshake against the CA on the provider listener and a plain connect on the CONNECT surface, which plain OAuth sessions use, each timed. A listener that does not accept fails the check naming the sessions it cuts off and the restart that replaces it. Refs #428
a5b8b23 to
5574008
Compare
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
doctorandfrontdoor statusreported a front door as healthy from its supervisor pid while every connection to both of its listeners timed out, because a door whose event loop is blocked is alive and accepts nothing (#424).Both commands now probe the serving door's listeners themselves: a TLS handshake against agent-shim's CA on the provider listener, and a plain TCP connect on the CONNECT surface, which every plain OAuth session reaches Anthropic through. Each is timed on its own. A listener that does not accept within the probe's bound fails the doctor check, names the sessions it cuts off and the restart that replaces it;
frontdoor statusprints one line per listener, and its JSON gains alistenerslist.The door's event-loop delay is not persisted to the state file, because releases that read it strictly would then treat it as malformed; the probe latency is the observable that matters to a session.
Refs #428.