feat: add MiniMax as configurable evaluation LLM provider (default M3)#351
Open
octo-patch wants to merge 2 commits into
Open
feat: add MiniMax as configurable evaluation LLM provider (default M3)#351octo-patch wants to merge 2 commits into
octo-patch wants to merge 2 commits into
Conversation
Add support for MiniMax M2.7 as an alternative LLM provider for benchmark evaluation (MagnifierBench, MathVista, MM-Vet) and the Syphus data generation pipeline. Previously, evaluation judging was hardcoded to OpenAI GPT-4. Changes: - Add pipeline/benchmarks/utils/eval_llm.py: Configurable evaluation LLM client supporting OpenAI and MiniMax providers with auto-detection via environment variables, temperature clamping, and think-tag stripping - Update magnifierbench.py, mathvista.py, mmvet.py to use configurable eval LLM client with backward-compatible eval_provider parameter - Update Syphus file_utils.py with MiniMax provider documentation and temperature clamping when MINIMAX_API_KEY is set - Add 24 unit tests and 4 integration tests - Update README with MiniMax configuration docs and badge
- Update default model to MiniMax-M3 in PROVIDER_CONFIGS - Document MiniMax-M2.7 and MiniMax-M2.7-highspeed as alternative models - Update README badge and configuration examples to M3 - Update unit and integration tests to expect M3 as default - Update Syphus pipeline docstring OPENAI_API_ENGINE example to M3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeline/benchmarks/utils/eval_llm.py) supporting OpenAI and MiniMax providers with auto-detection, temperature clamping, and think-tag strippingMiniMax-M3(512K context, 128K max output, image input support);MiniMax-M2.7andMiniMax-M2.7-highspeedremain availableeval_providerparameterMotivation
The benchmark evaluation system (MagnifierBench, MathVista, MM-Vet) previously hardcoded OpenAI GPT-4 as the evaluation judge LLM. This PR makes the evaluation LLM configurable, enabling users to choose alternative providers like MiniMax M3 — the latest MiniMax model with 512K context and image input support — as a cost-effective evaluation backend.
Configuration
Or via YAML config:
To target a specific MiniMax model instead of the default:
Changes
MiniMax model line
MiniMax-M3MiniMax-M2.7MiniMax-M2.7-highspeedTest plan
eval_provideris set