MID-10957 Filter deprecated sync action choices#650
Open
kay1313 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MID-10957: selecting the deprecated synchronization action
Unlinkin the resource object type editor could cause an internal server error.The action dropdown was offering deprecated synchronization action containers. When
Unlinkwas selected, wrapper creation skipped the deprecated newly-created item and returnednull; the dropdown code then dereferenced the missing wrapper and failed with aNullPointerException.Changes
ContainersDropDownPanelchoices by default.Testing
Unlinkis not offered as a new dropdown choice;Unlinkconfiguration opens safely;Unlinkcan be replaced bySynchronize;Manual verification:
Unlinkis no longer offered for new/normal synchronization reactions.Unlinkopens without HTTP 500.Unlinkcan be changed to supported actions such asSynchronizeorLink.