MID-11073 Fix threshold suspension in iterative scripting#629
Open
kay1313 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes MID-11073, where iterative scripting tasks did not suspend correctly when a threshold policy action was triggered from inside a script.
Problem
When an iterative script called a model operation such as
midpoint.modifyObject(delta), aThresholdPolicyViolationExceptioncould be wrapped by the script evaluation layer as anExpressionEvaluationException.Because error categorization checked only the top-level exception, the task treated the threshold violation as a normal script/item failure. The task then continued processing remaining objects and eventually finished as
Closed/Errorinstead of stopping asSuspended.Fix
Detect
ThresholdPolicyViolationExceptionin the exception cause chain, so wrapped threshold violations are still categorized asPOLICY_THRESHOLD.Test
Added an integration test for an iterative scripting task with:
suspendTaskThe test verifies that the task suspends after the threshold is reached, with 2 successful items and 1 threshold-triggering failure.