MID-8802 Added displayName and preferredName to UserType#621
Open
kay1313 wants to merge 2 commits into
Open
Conversation
1azyman
requested changes
Apr 29, 2026
Member
1azyman
left a comment
There was a problem hiding this comment.
- Release notes need a bit better description, mainly in:
** Upgrade From MidPoint 4.9 (to be renamed to 4.10), removed content that's not relevant for upgrade 4.10->4.11.
** Changes In Initial Objects Since 4.10, again remove content that's not relevant - Initial object template for person (380-something.xml) is missing display name mapping, which will take value from
preferredName(if it has value) or fromfullName. - I see few replacements in GUI from
fullName->displayName.
Customers will not have users withdisplayNamepopulated right after upgrade, wouldn't it be better to useWebComponentUtil.getDisplayNameOrName()or something similar new that will return something more gracefully likedisplayName/fullName/name(in this order)?
Or more probably inObjectTypeUtil.getDisplayName(ObjectType)return displayName or fullName...
I'm not sure, just to make it less painful for customers. I was looking atSidebarMenuItemPanel,UserSummaryPanel,AccessRequestMixin. Something that later can be "switched of" and to use onlydisplayNamein next versions.
I think this graceful handling is not relevant for reports and backend code. - More notes will be added as didn't have time to go through all the code yet.
| <previousColumn>activationColumn</previousColumn> | ||
| </column> | ||
| <column id="10"> | ||
| <column id="11"> |
Member
There was a problem hiding this comment.
Please revert container ids changes and only create new id for new container (display name column). They don't have to be ordered. If we leave it shifted like this, diff during upgrade will display more "fake" changes since container with id=8 is now different then in previous version. If just displayName(id=12) is added, only that one will be picked up when object is used during diff operation. There's also "natural keys" for some containers defined, but it's not everywhere, so we want to stay on safe side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces UserType.displayName and preferredName, and updates selected presentation paths to use displayName instead of fullName.
The goal is to separate:
Core behavior
displayName is now model-maintained:
Scope of changes
1. Schema & Repository
2. Model
3. Presentation (GUI)
Switched selected user-facing labels from fullName → displayName:
4. Search / Reporting
Added displayName to:
5. Notifications
What was intentionally NOT changed
This is a targeted presentation-layer shift, not a global rename.
Notes / impact
Detailed Impact (by area)
Result