Make inline authorship visible inside mixed paragraphs#6
Make inline authorship visible inside mixed paragraphs#6yusufaltunbicak wants to merge 1 commit intoEveryInc:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31890016c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case 'authored': { | ||
| style = getAuthoredDecorationStyle(mark.by); | ||
| cssClass = 'mark-authored'; | ||
| break; |
There was a problem hiding this comment.
Adding authored entries to createDecorations makes those spans carry the same data-mark-id metadata as suggestion/comment marks, so clicking normal authored text now routes through the popover handlers (mark-popover.ts checks closest('[data-mark-id]') and treats every non-comment mark as a suggestion). In documents where most text is authored, this causes routine clicks/taps to open an irrelevant suggestion popover (and on touch it also calls preventDefault), which interferes with normal editing/navigation.
Useful? React with 👍 / 👎.
1 participant
Small inline edits were already being tracked, but they were easy to miss in the editor.
If a human changed a few words inside an AI-authored paragraph, the gutter still looked fully AI-authored unless the edit created a new block. There also wasn't any inline cue showing which words were human vs AI.
This changes two things:
mixedin the gutterBefore / after
Testing
npx tsx src/tests/heatmap-authorship.test.tsnpm run build