Skip to content

feat(web): restructure the header into Lookup, Database, Tools, Guides, Chat and Profile - #1336

Draft
CDVolvik wants to merge 2 commits into
mainfrom
srdev/nav-20261116
Draft

CDVolvik wants to merge 2 commits into
mainfrom
srdev/nav-20261116

Conversation

@CDVolvik

Copy link
Copy Markdown
Collaborator

Part of #971 (the nav restructure from the 2026-11-16 audit comment, as the owner decided it).

What changed

Header. The top bar is now Lookup · Database · Tools · Guides · Chat · Profile. Chat is a link; the other five open a menu. The phone menu shows the same groups in the same order, then "More" with Chat, Docs and About.

Menu Links
Lookup Characters (only with EVERLOOT_PLAYER_PAGES), Census, Rankings, Guild board (Guilds with EVERLOOT_GUILDS), Auction House, Bag upgrades, Addons
Database Overview, Items, NPCs, Quests, Zones, Spells, World map
Tools Raid builder, Talent calculator, Professions, All tools (/tools)
Guides All guides, Legacy perks, Lore archive, Changes
Profile Account, Settings (EVERLOOT_PROFILES), My builds (EVERLOOT_SAVED_BUILDS), Gold ledger, Plans on this device, Alts on this device

The bar marks the item that holds the current page by its longest matching link, so /tools/gold-ledger marks Profile, not Tools.

Catalogue (data/tools.ts). Groups are now Lookup | Tools | Guides | Profile, in menu order. A new hidden flag covers Farming, Collections and Upload: they are left out of the menus, the /tools cards, the footer, the sitemap, site search and llms.txt. Their routes still load. Upload keeps its link in the account tabs ("Uploads") and in the page text that already pointed to it (addon page, addon pages).

/tools is one grid of cards in the order Raid builder, Talent calculator, Professions. Farming will join after Professions once it is unhidden.

Profile. Plans and Alts on this device are linked from Profile instead of Tools. Their routes and localStorage behaviour are unchanged. Their breadcrumbs now go Home › Account › page.

Footer. Guides is in Browse, "Guides feed (RSS)" sits after the changes feed, and "Upload addon data" is removed.

Home landing (app/page.tsx). Only one line changed: the tools card grid goes from 3 columns to 4 on wide screens, because it now has four groups. app/home/page.tsx is untouched.

Decisions for the maintainer

  • Crafting profit has no page of its own. It is the AH Ledger panel on each profession page, so I left it off the menu and cards rather than add a stub. Should it get a route (for example /tools/crafting), or does the Professions card cover it?
  • Docs is no longer in the wide header. It is in the phone menu (More) and the footer.
  • Bag upgrades stays in Lookup next to the Auction House until it moves to the character sheet.
  • Gold ledger moved to Profile (the audit's Profile → Gold). Its breadcrumb is unchanged.
  • Hidden pages keep their own robots settings. Leaving them out of the sitemap does not make them noindex.

Not done (out of scope)

  • The shared guides empty state from the issue body.
  • Renaming Collections to Completionist (wave 2).
  • The two lines in TOOL_NOTES in app/page.tsx for farming and collections are now unused. I left them alone to avoid touching the home lane's area.

How you tested it

  • npx vitest run --maxWorkers=4 --testTimeout=60000 (full web suite): 5949 passed, 2 failed, 30 skipped. Both failures are the known Windows ones in scripts/build-version.test.ts (spawnSync npm ENOENT).

  • npm run typecheck: clean. npm run lint: passes (within the 5-warning limit).

  • npx next build: succeeds.

  • New and updated tests:

    • header.test.tsx: bar order; each menu's links; switch variants; phone groups; current-item marking, including the longest-match menu link; hidden entries absent from the header, phone menu and footer.
    • header-menu / header-ask: open and close behaviour, and Chat marked current.
    • footer.test.tsx: Guides, the guides feed, no Upload link.
    • tools-index.test.tsx: card order; Farming and pages that moved are absent.
    • Sitemap, search, llms, breadcrumbs and seo tests updated for the hidden entries and the new Plans/Alts trails.
  • The title reads type(scope): plain sentence

  • Commits are signed off

  • No scraped, datamined or spoiler data

  • CHANGELOG.md has one line under [Unreleased]

  • The area label is set

…s, Chat and Profile

The top bar becomes six items. Lookup holds live data (characters with the
player pages on, census, rankings, guilds, Auction House, bag prices,
addons); Database the reference pages and the map; Tools the planners;
Guides the guides, Legacy perks, lore and changes; Chat is a link; Profile
holds the account pages, the gold ledger, and Plans and Alts on this
device. The phone menu shows the same groups in the same order.

/tools is one card per planner: Raid builder, Talent calculator,
Professions. Farming, Collections and Upload are hidden until polished:
a `hidden` flag in the catalogue keeps them out of the menus, cards,
footer, sitemap, site search and llms.txt; their routes still load, and
Upload stays reachable from the account tabs. The footer links Guides
and the guides feed. Plans and Alts trails now go through Account.

Part of #971

Signed-off-by: CDVolvik <cjimenez@r21digital.com>
@CDVolvik CDVolvik added the web everloot.app label Nov 18, 2026
@mrglgl-reviewer

Copy link
Copy Markdown

Summary: The PR restructures the site navigation into Lookup, Database, Tools, Guides, Chat and Profile, with a simplified /tools page showing only planners, hidden tools excluded from menus/sitemap/search, and Profile absorbing Plans/Alts. The change is large but well-contained, with comprehensive test updates covering the new structure, longest-match current-item logic, hidden-tool exclusion, and breadcrumb changes. No blocking defects found.

Standards
No rulebook violations found.

Spec
No linked issue, so no spec check.

Checked
  • migrations: n/a (no migrations in this PR)
  • auth/RLS/grants: n/a (no auth changes)
  • secrets/PII: n/a (no secrets or PII in changed files)
  • error paths: n/a (no external calls or write paths changed)
  • scale/concurrency: n/a (no pagination, loops, or concurrency changes)
  • repo rules: E1 free-services-only satisfied (no paid services added); E2 main-is-production satisfied (PR body documents vitest, typecheck, lint, next build); E3 public-mcp-behind-flag not applicable
  • tests: updated tests cover header order, menu links, phone groups, current-item longest-match, hidden entries absent from header/phone/footer, /tools card order, sitemap/search/llms exclusion, breadcrumbs, and footer links; failure paths covered for hidden tools and draft chooser exclusion
  • structure: changes match PR description; no dead code; Header, Footer, tools data, /tools page, breadcrumbs, sitemap, search, llms, and tests all updated consistently

R21 rulebook review

@mrglgl-reviewer mrglgl-reviewer Bot added the review:clean Mrglgl Reviewer verdict label Nov 18, 2026
Disenchanting (#1318) joins the Lookup group after Bag upgrades.

Signed-off-by: CDVolvik <cjimenez@r21digital.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:clean Mrglgl Reviewer verdict web everloot.app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant