Repository navigation
Conversation
…s, Chat and Profile The top bar becomes six items. Lookup holds live data (characters with the player pages on, census, rankings, guilds, Auction House, bag prices, addons); Database the reference pages and the map; Tools the planners; Guides the guides, Legacy perks, lore and changes; Chat is a link; Profile holds the account pages, the gold ledger, and Plans and Alts on this device. The phone menu shows the same groups in the same order. /tools is one card per planner: Raid builder, Talent calculator, Professions. Farming, Collections and Upload are hidden until polished: a `hidden` flag in the catalogue keeps them out of the menus, cards, footer, sitemap, site search and llms.txt; their routes still load, and Upload stays reachable from the account tabs. The footer links Guides and the guides feed. Plans and Alts trails now go through Account. Part of #971 Signed-off-by: CDVolvik <cjimenez@r21digital.com>
|
Summary: The PR restructures the site navigation into Lookup, Database, Tools, Guides, Chat and Profile, with a simplified /tools page showing only planners, hidden tools excluded from menus/sitemap/search, and Profile absorbing Plans/Alts. The change is large but well-contained, with comprehensive test updates covering the new structure, longest-match current-item logic, hidden-tool exclusion, and breadcrumb changes. No blocking defects found. Standards Spec Checked
R21 rulebook review |
Disenchanting (#1318) joins the Lookup group after Bag upgrades. Signed-off-by: CDVolvik <cjimenez@r21digital.com>
This was referenced Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #971 (the nav restructure from the 2026-11-16 audit comment, as the owner decided it).
What changed
Header. The top bar is now Lookup · Database · Tools · Guides · Chat · Profile. Chat is a link; the other five open a menu. The phone menu shows the same groups in the same order, then "More" with Chat, Docs and About.
EVERLOOT_PLAYER_PAGES), Census, Rankings, Guild board (Guilds withEVERLOOT_GUILDS), Auction House, Bag upgrades, Addons/tools)EVERLOOT_PROFILES), My builds (EVERLOOT_SAVED_BUILDS), Gold ledger, Plans on this device, Alts on this deviceThe bar marks the item that holds the current page by its longest matching link, so
/tools/gold-ledgermarks Profile, not Tools.Catalogue (
data/tools.ts). Groups are nowLookup | Tools | Guides | Profile, in menu order. A newhiddenflag covers Farming, Collections and Upload: they are left out of the menus, the/toolscards, the footer, the sitemap, site search and llms.txt. Their routes still load. Upload keeps its link in the account tabs ("Uploads") and in the page text that already pointed to it (addon page, addon pages)./toolsis one grid of cards in the order Raid builder, Talent calculator, Professions. Farming will join after Professions once it is unhidden.Profile. Plans and Alts on this device are linked from Profile instead of Tools. Their routes and localStorage behaviour are unchanged. Their breadcrumbs now go Home › Account › page.
Footer. Guides is in Browse, "Guides feed (RSS)" sits after the changes feed, and "Upload addon data" is removed.
Home landing (
app/page.tsx). Only one line changed: the tools card grid goes from 3 columns to 4 on wide screens, because it now has four groups.app/home/page.tsxis untouched.Decisions for the maintainer
/tools/crafting), or does the Professions card cover it?Not done (out of scope)
TOOL_NOTESinapp/page.tsxfor farming and collections are now unused. I left them alone to avoid touching the home lane's area.How you tested it
npx vitest run --maxWorkers=4 --testTimeout=60000(full web suite): 5949 passed, 2 failed, 30 skipped. Both failures are the known Windows ones inscripts/build-version.test.ts(spawnSync npm ENOENT).npm run typecheck: clean.npm run lint: passes (within the 5-warning limit).npx next build: succeeds.New and updated tests:
header.test.tsx: bar order; each menu's links; switch variants; phone groups; current-item marking, including the longest-match menu link; hidden entries absent from the header, phone menu and footer.header-menu/header-ask: open and close behaviour, and Chat marked current.footer.test.tsx: Guides, the guides feed, no Upload link.tools-index.test.tsx: card order; Farming and pages that moved are absent.The title reads
type(scope): plain sentenceCommits are signed off
No scraped, datamined or spoiler data
CHANGELOG.mdhas one line under[Unreleased]The area label is set