Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Design review ping for Evan: No doc amend needed this cycle — ready for human review as design-only draft. Open questions (non-blocking):
|
|
Maintenance (2026-09-27): re-checked CI: lint + typecheck green. mergeable_state clean. No review-comment nits to apply. Still design-only draft awaiting Evan human review (questions from prior ping stand). Not merging. |
|
Maintenance (2026-09-28): re-checked — still design-only, still prioritizes error-reproduction fields (#153/#136/#128/#103/#143/#102) and perf timing spans (TTFF, inject, camera interval, helper start/stop, reconnect). CI lint+typecheck green; mergeable clean. No doc amend this cycle. Awaiting Evan review. Not merging. |
|
Maintenance (2026-10-01): amended Error-repro: Perf spans: Still design-only draft. CI was green on the previous commit; this commit is docs-only. Not merging. |
|
Maintenance (2026-10-02): still design-only. Pushed
CI on the previous commit was green (lint + typecheck). This commit is docs-only. No review-comment nits. Still awaiting human review. Not merging. |
|
Maintenance (2026-10-04): pushed
No review-comment nits. Prior CI (lint + typecheck) was green; this commit is docs-only. Still design-only draft. Not merging. |
|
Maintenance (2026-10-05): pushed
No review-comment nits. Prior CI (lint + typecheck) was green; this commit is docs-only. Still design-only draft. Not merging. |
|
Maintenance (2026-10-06): pushed
No review-comment nits. Prior CI (lint + typecheck) was green on |
|
Maintenance (2026-10-07): pushed 223a619 on docs/observability.md. The worked records still emitted Error-repro: #128 stays Docs-only. Still a design draft. Not merging. |
|
Maintenance (2026-10-08): pushed
Docs-only. Prior lint + typecheck on |
|
Maintenance (2026-10-09): pushed
Docs-only. Prior lint + typecheck on |
|
Maintenance (2026-10-10): pushed Docs-only. Lint + typecheck on |
|
Maintenance (2026-10-11): re-checked CI lint + typecheck were green on the prior commit. No review comments. Still design-only draft awaiting human review. Not merging. (Note: a transient bad commit |
|
Maintenance (2026-10-12): re-checked CI lint + typecheck green on head. No review comments. Still design-only draft awaiting human review. Not merging. Note: new draft #166 (auth for exec/remote) has a unit CI failure; that is a prerequisite mentioned in this PR body. |
|
Maintenance (2026-10-13): re-checked draft. docs/observability.md continues to prioritize error-reproduction fields (#153 landscape miss: orientation/frame/remapped/source/screen_changed; #136 hid.state/gone; Device Hub shadow; #128 false stall vs producer; #103 connecting; #143 helper exit) and performance timing keys (input.send_ms, stream.ttff_ms, stream.reconnect_ms, camera.frame_interval_ms, camera.helper_shutdown_ms, helper.uptime_ms) on the existing event log. Worked examples distinguish hit vs miss vs dead injector without extra spans. CI: lint + typecheck green on latest. No review comments or merge conflicts. Related implementation for the coordinate remap is in draft #167 (CI green, Darwin matrix confirmed). Still design-only. Awaiting human review before implementing the additive fields. Not merging. |
|
Maintenance (2026-10-14): re-checked |
|
Maintenance (2026-10-15): re-checked Perf timing spans/keys stay gated by the repro fields so a landscape or headless miss still records Proposed additive field CI lint + typecheck green. No review-comment nits. Still design-only draft. Not merging. |
|
Maintenance (2026-10-16): re-checked docs/observability.md. Still design-only draft prioritizing error-reproduction fields (coord_space, orientation, frame, remapped, source, screen_changed, hid.state, inject.result, input.shadowed) for #153/#136/#128/#103/#143/#102 and performance timing (input.send_ms, stream.ttff_ms, stream.reconnect_ms, camera.helper_shutdown_ms, etc.). Related: draft #167 (landscape CLI remap for #153) is open with green CI (unit/lint/typecheck/sim-test). The proposed log fields remain the way to distinguish a remaining coordinate miss (or --raw / auth refusal) from a dead injector or Device Hub shadow after #167 merges. CI on this PR: lint + typecheck green. mergeable_state clean. No review comments or CI failures to address. Still awaiting human review. Not merging. |
|
Maintenance (2026-10-17): re-checked Error-reproduction fields remain primary (orientation/frame/remapped/source/screen_changed, hid.state, inject.result, shadowed). Timing keys stay gated by those fields so landscape misses (#153) and dead injectors (#136) are distinguishable, and false stalls (#128) / stuck Connecting (#103) omit the misleading duration keys. New related issue #172 (portrait silent tap drop on iPhone 18 Pro / iOS 27) would be diagnosed by the same fields; no doc amend needed this cycle. CI (lint + typecheck) green on head; mergeable clean. Still design-only draft. Not merging. |
|
Maintenance (2026-10-18): re-checked docs/observability.md. Error-reproduction fields (orientation/frame/remapped/source/screen_changed/hid.state) and timing keys (input.send_ms gated by them) remain primary. New #172 (portrait silent tap drop on iPhone 18 Pro / iOS 27) is a candidate for the same signature: orientation=portrait + hid.state=ok + screen_changed=false would distinguish a device-specific HID/frame miss from #153 landscape remap and #136 dead injector. No code change this cycle; still design-only draft. CI green, no review nits. Not merging. |
|
Maintenance (2026-10-20): re-checked New issues #172 (portrait silent tap drop on iPhone 18 Pro / iOS 27) and #174 (browser paste not reaching guest; CoreDevice clipboard works) are related to the silent-failure family but do not yet have dedicated log fields; the existing hid.state + screen_changed + source should distinguish most drops. No doc amend this cycle. CI: lint + typecheck green (last run 2026-10-14). mergeable_state clean. No review comments. Still design-only draft awaiting human review. Not merging. |
|
Maintenance (2026-10-21): re-checked CI: lint + typecheck green on last run. mergeable_state clean. No review comments or nits to address. Design-only draft; not merging. Awaiting human review on the open questions from earlier pings. |
|
Maintenance (2026-10-22): re-checked New related open issues: #172 (portrait tap silent drop on iPhone 18 Pro / iOS 27) and #174 (browser paste / CoreDevice clipboard). Both would be diagnosed from the same log once the fields land (screen_changed=false + hid.state=ok distinguishes coordinate vs dead HID vs clipboard path). CI lint+typecheck green on last push; mergeable_state clean. No review comments. Still design-only draft. Not merging. No doc amend this cycle — the worked records and omit rules already cover the priority items. |
|
Maintenance (2026-10-23): Re-checked Performance timing keys stay gated by those fields (input.send_ms present on landscape miss and shadow, omitted on hid.state=gone/ack=timeout; stream.reconnect_ms / ttff_ms omitted on false stall and stuck Connecting). New open issues #172 (portrait tap drop on iPhone 18 Pro / iOS 27) and #174 (browser paste / CoreDevice clipboard) fit the same silent-failure family; the existing fields should distinguish them once logs are collected. No doc amend this cycle. CI lint + typecheck green on head. mergeable_state clean. No review comments. Still design-only draft awaiting human review. Not merging. |
Error-repro fields already land on the existing log. Timing is the same entries, not a span tree: input.send_ms, stream.ttff_ms, stream.reconnect_ms, camera.frame_interval_ms, camera.helper_shutdown_ms. Omit a duration when it would bucket a #128 false stall or a #103 stuck Connecting with a real reconnect, and omit input.send_ms when hid.state=gone so a dead injector is not a 4ms send.
Restore the broken tip file, clarify remapped vs observed_orientation, avoid writing poll results into broadcast orientation, fix screen_changed timing, stall field (producer_frame_age), helper lifecycle hooks, and note the PR #166 dependency for remote event-log readback.
Co-authored-by: Evan Bacon <baconbrix@gmail.com>
…field/source fixes
…ordTouchEvent Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…intenance notes - Banner: status is proposal; only 'records today'/'reads back' describe main. - #166 and #167 are merged: describe the auth gate (remoteAccess 403/401, loopback trusted) and the CLI remap as current, not pending. - Event log source now includes 'capture' (duo.renderer); note /api/diagnostics (loopback-only) exposes the last 100 entries. - Fix broken repro-field table and dangling 'Privacy below' reference. - #174: there is no clipboard path in serve-sim; reword as a privacy rule. - Remove dated maintenance notes and the duplicated #172/#174 section.
…t frame arrival The idle timer re-emits unchanged frames every 200 ms, so frameSeq always advances after a touch; onSharedMjpegFrame also only runs on foldables.
Rebased onto main. Recent-PR notes keep proposed event-log fields aligned with Duo hinge CoreMotion readback, fake-camera unique-ID swizzle, and the async shutdown boot query. Claude Code signed off on the doc pass.
1366ae7 to
dcf9962
Compare
|
Maintenance (2026-11-10): re-checked |
|
Maintenance (2026-11-11): re-checked CI: lint + typecheck green. mergeable_state clean. Review comments previously addressed (screen_changed content-stamp not frameSeq). No doc amend needed this cycle. Still awaiting human review. Not merging. |
|
Maintenance pass (2026-11-12): Draft PR still open, CI green (lint/typecheck success). Observability design continues to prioritize error-reproduction fields ( No new review comments to address. Doc remains proposal-only; implementation of the fields is a follow-up. Next: confirm any recent main changes (e.g. #189-#191 notes already incorporated) and keep hooks current. |
|
Maintenance (2026-11-13): re-checked |
|
Maintenance (2026-11-14): re-checked draft. Docs-only design still prioritizes error-reproduction fields ( |
|
Maintenance (2026-11-15): re-checked draft. Docs still correctly prioritize error-reproduction fields ( |
|
Maintenance (2026-11-16): re-checked draft. Docs still correctly prioritize error-reproduction fields (coord_space, orientation/observed_orientation, frame, remapped/remap_expected, source, screen_changed, hid.state, inject.result, ack) and performance timing spans (input.send_ms, stream.ttff_ms, stream.reconnect_ms, etc.). Hooks current with recent PRs (#189-#192). CI lint+typecheck green; mergeable clean. No amend needed this cycle. Awaiting human review. Not merging. |
Docs-only. No runtime code, dependencies, or CI changes.
Rebuilds
docs/observability.mdon the event log serve-sim already has (src/event-log.ts, surfaced atGET /api/event-log, the/api/event-log/eventsSSE stream, andserve-sim event-log --json). It documents what that log records today, the small additive fields that make our silent failures reproducible from the log alone, and names the exact hook that produces each field.What it covers
schema_versionon the response envelope.coord_space,orientation(read fromscreenConfig()at record time, and kept current for rotations outside0x07via theonSharedMjpegFramedimension-swap observe path / a non-Duo orientation poll mirroringDuoStateMonitor.refreshOrientation),frame(display vs native_portrait),remapped(rawPointForDisplayPoint), andsource(cli vs web) added compatibly to the0x03payload and read inrecordTouchEvent.onSharedMjpegFrame, written back onto the tap entry withupdateEventLogEventasscreen_changed.fold(0x0e) waits for a reply;tap/gesture/rotate/buttonare fire-and-forget. The ack proves the server received and dispatched the frame to the native injector (NativeHid.touch->SimHIDHandle.touch, wrapped byguard()innative.ts); it does not prove the guest UI reacted -- that's whatscreen_changedis for.isDeviceHubInputShadowed/com.apple.coredevice.dtuhidd.active), helper lifecycle (classifyStaleState,startSimulatorShutdownWatch), and the corrected Native MJPEG preview can show false frame-stall error after rotation #128 (the watchdog is on thefetch()reader, not<img>) and Flaky: SimCameraHelper shm probe — helper exits with a signal during shutdown (bisected to 14ad57f) #143 (supervising parent captures exit code and signal; SIGPIPE is already ignored) notes.OTEL_EXPORTER_OTLP_ENDPOINT; the correct debug switches (DEBUG=serve-sim:*,SERVE_SIM_DEBUG_HID-- there is noSERVE_SIM_DEBUG).event-log,device-hub-input, andhelper-lifecycletests.The span-tree, histogram buckets, and OpenTelemetry-survey material from the earlier draft are gone; this is scoped to the event log and names only hooks that exist.
Prerequisite
The guide points agents at
GET /api/event-logandserve-sim event-log --jsonon a possibly-remote server. The auth that makes those endpoints safe to reach off-loopback comes from the serve-sim auth/exec security fix (branchfix/api-exec-auth); merge that first.Design/docs-only -- the field additions it proposes are small and additive, each pinned to a named hook, to be implemented and tested separately.
Summary by CodeRabbit