Feature/configurable arch baseline - #125
Open
pplupo wants to merge 2 commits into
Open
Conversation
Add x64-linux-v2 (default) and x64-linux-baseline overlay triplets and thread ARCH_TRIPLET/ARCH_MARCH_FLAGS build args through the core cmake invocation, so downstream builders can compile against plain x86-64 without the team maintaining a second officially-supported toolchain. Signed-off-by: Peter P. Lupo <pplupo@gmail.com>
Both custom overlay triplets omitted this setting, which vcpkg's own community x64-linux triplet always includes. Without it vcpkg defaults to assuming a Windows target and tries to detect a Visual Studio Developer Prompt toolchain, which fails outright on a Linux host: 'Use of Visual Studio's Developer Prompt is unsupported on non-Windows hosts.' Only surfaced now since this is the first build to actually exercise these triplets end-to-end. Signed-off-by: Peter P. Lupo <pplupo@gmail.com>
pplupo
force-pushed
the
feature/configurable-arch-baseline
branch
from
July 22, 2026 21:56
06659fd to
acaf3a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the target x86-64 microarchitecture baseline for Linux builds configurable, instead of hardcoding it. Adds vcpkg overlay triplets (
x64-linux-v2default,x64-linux-baselinefor plain x86-64) and threadsARCH_TRIPLET/ARCH_MARCH_FLAGSthrough the Docker bake config andbuild.sh.Why
Raising the official baseline to x86-64-v2 (SSE4.2/POPCNT) gives Qt and other vcpkg-built dependencies access to SIMD-optimized code paths instead of falling back to unoptimized generic code — but it drops support for older CPUs that predate v2. Rather than the team maintaining a second, permanently-tracked toolchain to support that hardware, this exposes the microarchitecture as a build-time parameter so anyone who needs a legacy build can produce one themselves from the same sources, without affecting the default build path.
Changes
core: addstriplets/x64-linux-v2.cmake(default) andtriplets/x64-linux-baseline.cmakevcpkg overlay triplets; wiresARCH_TRIPLET/ARCH_MARCH_FLAGSbuild args into the core cmake invocation in.docker/core.bake.Dockerfile.desktop-apps: same args threaded through.docker/desktop-apps.bake.Dockerfile's vcpkg/cmake invocation, since Qt is built there via the vcpkg manifest.ARCH_TRIPLET(defaultx64-linux-v2) andARCH_MARCH_FLAGS(default-march=x86-64-v2) inbuild/docker-bake.hclandbuild/linux/docker-bake.hcl, and exposes them as overridable environment variables inbuild/linux/build.sh.Usage
Default behavior is unchanged. To produce a baseline x86-64 build:
```sh
ARCH_TRIPLET=x64-linux-baseline ARCH_MARCH_FLAGS=-march=x86-64 ./build.sh
```
Scope / non-goals
#125
Euro-Office/desktop-apps#35
Euro-Office/DesktopEditors#61