SpreadSheet Editor Dark Mode (dark document) 🌘 — e2e smoke tests - #310
Draft
j-base64 wants to merge 8 commits into
Draft
SpreadSheet Editor Dark Mode (dark document) 🌘 — e2e smoke tests#310j-base64 wants to merge 8 commits into
j-base64 wants to merge 8 commits into
Conversation
Add Playwright smoke tests covering basic editing in each editor: - document: type text, apply bold/italic, verify text round-trips - spreadsheet: enter numbers and a formula, verify it is accepted - presentation: build a three-slide deck Shared helpers open a new document from the example app and reach the editor automation API inside the iframe. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Julius Knorr <jus@bitgrid.net>
Covers the toggle button, interface-theme/content-dark-mode interaction, cell color/border/merge/search-highlight/resize-guide rendering, mid-edit toggle behavior, and print-preview isolation from content dark mode. One test per file under e2e/tests/spreadsheeteditor/darkmode/, registered via the spreadsheeteditor-darkmode.spec.ts index (run with --workers=1 to avoid overloading the shared dev container). helpers.ts gains frameEval arg support and a shared expectColorClose assertion. Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
…x in favor of plain spec files) Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
…rage Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
…present in initial codebase) Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
…ments, update isColorDark threshold Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
…mode tests Signed-off-by: j-base64 <jcentenero@arsys.es> Assisted-by: ClaudeCode:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Origin
Issue Euro-Office/web-apps#117 pinpointed the lack of dark mode in the spreadsheet editor.
The fix required changes to both
sdkjsandweb-appsand led to two PRs :This PR propose 🌈
13 smoke tests covering: Cell fill/border/text correction, merged cells, page-break-preview, gradient/pattern fill in the cell editor, print-preview, column-resize guide color, search-highlight contrast, mid-edit-toggle behavior, interface-theme interaction, and toolbar sync.
Note about CI Fail ❌
These e2e tests are designed to work with the dark-mode code introduced by the
web-appsandsdkjscompanion PRs (see above). Until those companion PRs are merged to their respectivemainbranches, thee2e (pull_request)check is expected to fail, by design, not due to aregression.
Note about files location
These e2e tests are proposed in the place where e2e tests were introduced through PR
#197. To see if needed in a future to move
them to a better place or exclude them from the default Playwright run (opt-in only).
AI assistance
claude-sonnet-5)