Skip to content

Remove redundant default value handling from gesture settings UI. fix…#278

Merged
Ethran merged 2 commits into
mainfrom
dev
Jun 29, 2026
Merged

Remove redundant default value handling from gesture settings UI. fix…#278
Ethran merged 2 commits into
mainfrom
dev

Conversation

@Ethran

@Ethran Ethran commented Jun 29, 2026

Copy link
Copy Markdown
Owner

#273

UI & ViewModels

  • SettingsViewModel:
    • Removed the defaultValue property from the GestureRowModel data class.
    • Updated the gestureRows list to remove explicit default action assignments for various gesture types.
  • GesturesSettings:
    • Removed the defaultAction parameter from the GestureSelectorRow composable.
    • Updated SelectorRow to use currentAction directly instead of falling back to a default value.
  • Settings (Views): Updated SettingsPreviewGestures to reflect the simplified GestureRowModel structure in UI previews.

Ethran added 2 commits June 29, 2026 10:01
…273

### UI & ViewModels
- **SettingsViewModel**:
    - Removed the `defaultValue` property from the `GestureRowModel` data class.
    - Updated the `gestureRows` list to remove explicit default action assignments for various gesture types.
- **GesturesSettings**:
    - Removed the `defaultAction` parameter from the `GestureSelectorRow` composable.
    - Updated `SelectorRow` to use `currentAction` directly instead of falling back to a default value.
- **Settings (Views)**: Updated `SettingsPreviewGestures` to reflect the simplified `GestureRowModel` structure in UI previews.
@Ethran Ethran merged commit 719945d into main Jun 29, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant