Conversation
… update testing dependencies.
### Core & Data
- **DomainError**: Simplified the `plus` operator implementation using safe casts and the elvis operator.
- **Kv (Dao, Repository, Proxy)**:
- Removed `getLive` and `observeKv` methods to streamline the API towards coroutines.
- Updated `KvProxy` to explicitly enable `ignoreUnknownKeys` in JSON decoding.
- **FolderSyncService**: Improved readability of update logic with additional parentheses.
### IO & Utils
- **XoppFile**: Refactored `fastParseFloat` to use a more idiomatic `when (val c = ...)` expression and grouped character branches.
- **Formatting**: Added trailing commas and improved line wrapping in `SyncSettings`, `checkPermissions`, and `DomainError` for better maintainability.
### Testing
- **EditorUnsupportedConcurrentChangeTests**:
- Migrated to `androidx.compose.ui.test.junit4.v2.createComposeRule`.
- Removed unused coroutine imports (`delay`, `filter`, `first`, `withTimeout`).
- Standardized line breaks for long log messages and assignments.
…factor UI components for better performance.
### Build
- **Gradle**:
- Migrated `compose_version` from the root `build.gradle` to the Version Catalog (`libs.versions.toml`).
- Fixed property access logic for `IS_NEXT` and updated `projectDir` references to use `project.projectDir`.
- Moved Robolectric `jvmArgs` configuration to a global `tasks.withType(Test)` block.
- Corrected dependency scopes for `androidx.junit.ktx` and `room.testing.android` from `implementation` to `androidTestImplementation`.
### UI & UX
- **Switch**: Refactored thumb offset to use the lambda-based `Modifier.offset` with `IntOffset` to improve performance by avoiding recomposition during animations.
- **SyncSettingsTab**: Updated the auto-sync label to support pluralized string resources.
### Localization
- **Strings (English & Polish)**: Converted `sync_auto_sync_label` and `sync_clock_skew_warning` into `<plurals>` to correctly handle singular and plural time units (minute/minutes, second/seconds).
### Core & Testing
- **XoppFile**: Refactored bounding box initialization for clarity and updated KDoc references.
- **EditorSelectionThreadSafetyTests**:
- Updated timeouts and delays to use Kotlin `Duration` APIs (`5.seconds`, `16.milliseconds`).
- Simplified flow collection logic using `first { ... }` predicates.
- Improved reflection-based delegate access and added sequence-based filtering.
- **FolderSyncService**: Minor code style and formatting improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.