Conversation
### Build - **app/build.gradle**: Excluded `com.tencent:mmkv` from both `onyxsdk-pen` and `onyxsdk-base` dependencies.
### UI & UX - **LastSyncInfo**: Refactored to use `LocalConfiguration.current.locales` for localized date formatting instead of the default locale. - Cleaned up trailing whitespace and improved indentation across multiple composable functions for better readability. - Reorganized parameters and line breaks in `EInkActionButton`, `EInkSection`, and various `Text` components to comply with standard formatting guidelines.
### UI & UX
- **SyncSettingsTab**:
- Externalized hardcoded strings in the experimental sync warning dialog to `strings.xml`.
- Added vertical scrolling to the sync settings layout.
- Removed redundant comments.
### Localization
- **Strings (English & Polish)**:
- Added new strings for experimental sync warnings and export errors.
- Fixed a typo in the Polish translation for Onyx device instructions ("Odmrizić" to "Odmrozić").
### Sync & Core
- **SyncSettings**: Added `uploadOnly` boolean property to manage the new sync mode.
- **SyncOrchestrator**:
- Updated sync logic to skip remote deletions and new notebook downloads when `uploadOnly` is enabled.
- Introduced `finalizeSyncResult` to handle non-critical `SyncUploadOnlySkip` errors.
- **NotebookReconciliationService**: Modified `syncNotebook` to return a `SyncUploadOnlySkip` error instead of downloading when remote changes are detected in upload-only mode.
- **FolderSyncService**: Updated `syncFolders` to skip applying remote folder changes to the local database when `uploadOnly` is active.
- **DomainError**: Added `SyncUploadOnlySkip` error type and `isOnlyUploadSkip()` helper to identify non-critical upload skips.
### UI & Resources
- **Strings**: Added labels for the "Upload only" setting in English and Polish; shortened existing WebDAV labels.
- **SyncSettingsTab**: Added a toggle for the `uploadOnly` setting.
### Testing
- **SyncOrchestratorTest**: Added unit tests for `finalizeSyncResult` to ensure upload-only skips are treated as successful syncs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.