Codebase cleanup

[Jakubk15]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive codebase cleanup, primarily by refactoring repository method names for better consistency, standardizing delete operation return types, and reorganizing parcel-related services into a dedicated package. It also includes optimizations to caching mechanisms and enhancements to input validation, leading to a more robust and maintainable system.

Highlights

• Repository Method Renaming: Renamed data access methods from fetch to find and fetchAll to findAll across ParcelContentRepository, DeliveryRepository, LockerRepository, and ParcelRepository interfaces and their ORMLite implementations for improved naming consistency.
• Standardized Delete Operations: Modified the return type of delete methods in several repositories and services from CompletableFuture<Integer> (rows affected) to CompletableFuture<Boolean> (success/failure), simplifying the API for deletion operations.
• Package Restructuring for Parcel Services: Moved ParcelDispatchService, ParcelService, and ParcelServiceImpl into a new com.eternalcode.parcellockers.parcel.service package to enhance modularity and code organization.
• Optimized ParcelService Caching: Removed redundant sender-specific and receiver-specific caches from ParcelServiceImpl, now relying solely on the parcelsByUuid cache and direct repository calls for paged results, which simplifies caching logic and reduces memory overhead.
• Enhanced Input Validation: Introduced Objects.requireNonNull and Preconditions.checkArgument checks in ParcelServiceImpl and ParcelRepositoryOrmLite to improve input validation and overall robustness of the application.
• New Database Error Message: Added a specific databaseError notice message in MessageConfig to provide clearer feedback to users in case of database-related issues during parcel collection.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a significant codebase cleanup, improving consistency and maintainability. Key changes include standardizing repository method names (e.g., fetch to find), simplifying caching logic in ParcelServiceImpl, and improving return types for better clarity (e.g., delete methods now return a boolean). The introduction of null-checks and constants for magic values further enhances code quality.

However, I've identified two critical issues in ParcelServiceImpl related to asynchronous operations and data consistency that need to be addressed. One is a potential race condition in the send method's error handling, and the other is an incorrect order of operations in the collect method which could lead to item duplication.

[Copilot]

Pull request overview

This PR performs a comprehensive refactoring of the codebase to improve consistency and code quality. The changes include renaming repository methods from fetch* to find*, changing return types from Optional<List<T>> to List<T>, and from Integer to Boolean for delete operations. Additionally, the PR reorganizes package structures by moving service classes into a dedicated service subpackage, removes unused caching layers, adds null validation checks, and introduces new constants for improved maintainability.

Key changes:

• Standardized repository method naming convention from fetch* to find* across all repositories
• Changed delete method return types from Integer (row count) to Boolean (success/failure) for clearer semantics
• Simplified caching strategy in ParcelServiceImpl by removing sender/receiver-specific caches and relying on UUID-based cache only
• Added comprehensive null validation using Objects.requireNonNull() and Preconditions.checkArgument() throughout service layer

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ParcelRepositoryIntegrationTest.java	Updated test to use renamed repository methods (findById, findByReceiver, findBySender) and removed unused imports
LockerRepositoryIntegrationTest.java	Updated test to use renamed repository methods (find, findPage)
ParcelSendTask.java	Updated import to reflect new service package structure
ParcelServiceImpl.java	Major refactoring: moved to service subpackage, added null validations, removed sender/receiver caches, added defensive copying of items, improved error handling with exceptionallyCompose, and extracted magic strings/numbers to constants
ParcelService.java	Moved to service subpackage and changed delete method return types from Integer to Boolean
ParcelDispatchService.java	Moved to service subpackage and removed obsolete comment
ParcelRepositoryOrmLite.java	Renamed methods from fetch* to find*, changed delete return types to Boolean, removed fetchPage method, added null validations, and improved pagination result immutability
ParcelRepository.java	Updated interface to reflect renamed methods, removed fetchAll, removed fetchPage, and changed delete return types
LockerRepositoryOrmLite.java	Renamed methods from fetch* to find* and removed unused fetchAll method
LockerRepository.java	Updated interface to reflect renamed methods and removed unused import
LockerManager.java	Removed unused getOrCreate method and updated method calls to use renamed repository methods
ParcelListGui.java	Changed comment from fixme to todo for known issue
GuiManager.java	Updated imports to reflect new service package structure
DeliveryRepositoryOrmLite.java	Renamed methods from fetch* to find* and changed delete return type to Boolean
DeliveryRepository.java	Updated interface to reflect renamed methods and changed types
DeliveryManager.java	Removed unused getOrCreate method and updated method calls
ParcelContentRepositoryOrmLite.java	Renamed fetch to find and changed delete return type to Boolean
ParcelContentRepository.java	Updated interface to reflect renamed methods and changed types
ParcelContentManager.java	Updated method calls to use renamed repository methods
MessageConfig.java	Added new databaseError notice message for database operation failures
DebugCommand.java	Updated import to reflect new service package structure
ParcelLockers.java	Updated imports and method calls to use renamed repository methods

Comments suppressed due to low confidence (3)

src/main/java/com/eternalcode/parcellockers/parcel/service/ParcelServiceImpl.java:78

• The items list should be validated for null elements before cloning. If the items list contains null elements, this will throw a NullPointerException during the stream operation.
  src/main/java/com/eternalcode/parcellockers/parcel/service/ParcelServiceImpl.java:118
• After a rollback failure, the method returns a failed future containing an exception, but the deletion result is not checked. If the rollback delete fails, the parcel may remain in the database while the user receives an error message. Consider logging the deletion result or handling the rollback failure explicitly.
  src/main/java/com/eternalcode/parcellockers/parcel/service/ParcelServiceImpl.java:242
• When the cached value is null but a UUID needs to be invalidated, this creates unnecessary branching logic. The UUID should be invalidated directly since it's the same value.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.