Repository navigation
Conversation
Also: a command told where its files are (--policy, --store, --config or their variables) doesn't pick up a setup found elsewhere, whose database URL replaced ROWBIT_DATABASE_URL; this made the review tests fail on a machine with a demo in ~/rowbit-demo. Signed-off-by: Ermag <ermag.bg@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: main had the v0.2.3 first-run fixes (#48 to #52) under version 0.2.2, with #48's entry under "Unreleased". Separately,
rowbit-cli's review tests failed on a Mac with a demo in~/rowbit-demo. They point at their files withROWBIT_POLICYandROWBIT_STORE, but the new setup discovery still picked up the demo, and the demo's database URL replaced the test'sROWBIT_DATABASE_URL. The same would happen to anyone's scripts that point at files this way.After:
Cargo.toml,Cargo.lockand the plugin. The spec status line now says v0.2.3, and "Not in v0.2.3" drops multiple tokens per agent (now shipped) and adds expiring tokens and a token-from-env.mcp.json.--single, the Added items from rowbit connect finds the setup from any project folder #49 to rowbit status and the review page's Setup view #52, and Proposing the same write again withdraws the older held copy #48's fix moved under Fixed.--policy,--store,--configor their variables no longer looks for a setup in~/.rowbitor the demo. There's no CHANGELOG entry for this, since the bug never shipped.v0.2.2gets bumped in a site PR after the tag, following the usual order.How:
Ran
cargo test --workspacelocally against all three test databases with the demo's folder at~/rowbit-demo. Everything passes, includingreview.rs.clippy and fmt pass.
Tests cover the new behaviour
docs/spec/is updated if this changes the change lifecycle orrowbit.yml