Repository navigation
Conversation
Without --dir and with no Rowbit files in the current folder, commands now look at every setup in ~/.rowbit and the demo (linked as ~/.rowbit/demo), use the only one and say which, list them when there are several, and say to run rowbit setup when there are none. So `cd my-app && rowbit connect claude-code` works. Each client entry gets a token of its own, labelled with the client and project, so connecting a second project no longer signs out the first; rowbit agents lists them. Signed-off-by: Ermag <ermag.bg@gmail.com>
Review page addresses and docs links are OSC 8 links in terminals known to show them (Ghostty, iTerm2, WezTerm, kitty, VS Code, ...), plain elsewhere; ROWBIT_HYPERLINKS overrides. rowbit demo opens the review page in the browser once it answers (--no-open skips). The MCP instructions and the skill ask agents to give the review link as a Markdown link. Signed-off-by: Ermag <ermag.bg@gmail.com>
2 tasks done
Signed-off-by: Ermag <ermag.bg@gmail.com>
…ew is written - rowbit agents lists each token with an id; rowbit agents revoke <agent> --connection <id> signs out one, --single only the token from before 0.2.3. - A reconnect's old token is revoked only once the client entry holding the new one is written, so a failed connect leaves the old entry working. - Printed tokens are labelled with their time, so they don't replace one another. - --new-token revokes the single token from before 0.2.3; without it, connect says the agent still has one. - Marking a token used can't bring back a revoked connection's row. - needs_files finds connect's arguments wherever it sits; "here" compares canonical paths; a setup named demo isn't called the demo. Signed-off-by: Ermag <ermag.bg@gmail.com>
- Agents give the review link with the URL as its text, so people see where it goes. - rowbit demo opens the browser once its own server has bound, never another left on the port; not over SSH or on Linux without a display. - Control characters are removed from OSC 8 links. Signed-off-by: Ermag <ermag.bg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #49 (both touch the end of
setup's anddemo's output). Retarget to main once #49 merges.Before: Links in
rowbit setupoutput, and in the agent's reply after a write was held, weren't clickable in Philip's terminal (Ghostty). Rowbit printed plain URLs, so whether they were clickable depended on the terminal noticing them. Ghostty, for example, only opens a plain URL on ⌘-click.After:
setup,demoandserve) and the scopes docs link are marked as links with OSC 8. This only happens in terminals known to show OSC 8 links: Ghostty, iTerm2, WezTerm, kitty, VS Code, Windows Terminal, Hyper, Rio, Warp and VTE-based terminals. The link text is the URL itself, so copying it still works. Output that isn't going to a terminal, Terminal.app, tmux and screen all get the plain URL.ROWBIT_HYPERLINKS=1or0overrides the detection.rowbit demo(andsetup --sample) opens the review page in the browser once the page answers, and says so.--no-openturns this off. It only happens when the demo runs in a terminal, so CI is unaffected.[Review change 4](…)). Clients that render Markdown, Claude Code included, then show it as a clickable link.How:
Review fixes (v0.2.3 review):
Visible link target: agents give the review link with the URL itself as the link text (
<http://…/changes/4>), so people see where it goes. This changes the MCP instructions, the skill and the spec. (Point feedback to a GitHub discussion and refresh the README #3)Opening the browser:
rowbit demoopens it from a callback once its own server has bound the address, so it never opens another server left on that port. It doesn't open over SSH, or on Linux without a display.https://public URLs work. (Apply approved changes by primary key, and undo them #10)Nits: control characters are stripped from OSC 8 links, and new tests cover the browser checks.
Tests cover the new behaviour
docs/spec/is updated if this changes the change lifecycle orrowbit.yml