Repository navigation
chore: remove empty placeholder files and unused classes - #33
Merged
Merged
Conversation
yash-agarwa-l
changed the title
flink-jobs/pom.xml, flink-jobs/.../WordCountJob.java and docs/architecture.md were all 0 bytes. KubernetesService and OperatorConfig were never referenced. OperatorConfig is deleted rather than wired into GreenOpsReconciler: the reconciler already defines its own RECONCILE_INTERVAL_SECONDS and DEFAULT_CARBON_THRESHOLD was unused, so the class was dead code. Closes Ergane-Foundation#19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Deletes files that were empty or never referenced:
flink-jobs/pom.xmlandflink-jobs/src/main/java/com/greenops/jobs/WordCountJob.java(0 bytes)docs/architecture.md(0 bytes)operator/src/main/java/com/greenops/service/KubernetesService.java(unused)operator/src/main/java/com/greenops/config/OperatorConfig.java(unused)Why
Placeholder files confuse newcomers. The issue lets us either delete
OperatorConfigor haveGreenOpsReconcileruse its constant. I deleted it: the reconciler already has its ownRECONCILE_INTERVAL_SECONDSand nothing usesDEFAULT_CARBON_THRESHOLD, so the class was dead code and deleting it changes no behaviour.Closes #19
How it was tested
mvn -f operator/pom.xml verifypasses.flink-jobsorarchitecture.md.Checklist
fix(operator): ...make testpasses (no behaviour change, so no new tests)