Skip to content

Fix #620: Prevent zero amount checkouts and subtractions #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyleclarktech wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Fix #620: Prevent zero amount checkouts and subtractions #1053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0c4986
Fix #620: Prevent zero amount checkouts and subtractions
Jan 17, 2026
080a411
Merge branch 'development' into fix/620-prevent-zero-checkouts
GregJohnStewart Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...bp/oqm/core/api/service/mongo/transactions/appliers/CheckoutAmountTransactionApplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ public void apply(
if (transaction.isAll()) {
amount = stored.getAmount();
}


if (amount.getValue().equals(0)) {
throw new IllegalArgumentException("Amount to checkout must be greater than zero.");
}

ItemCheckout.ItemCheckoutBuilder<?, ?, ?> checkoutBuilder = ItemAmountCheckout.builder()
.checkedOutByEntity(interactingEntity.getId())
.item(inventoryItem.getId())
Expand Down
6 changes: 5 additions & 1 deletion ...bp/oqm/core/api/service/mongo/transactions/appliers/SubtractAmountTransactionApplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ public void apply(
if(toSubtract == null){
throw new IllegalStateException("Cannot subtract an amount from a null value. Should not get here.");
}


if (toSubtract.getValue().equals(0)) {
throw new IllegalArgumentException("Amount to subtract must be greater than zero.");
}

stored.subtract(toSubtract);

affectedStored.add(stored);
Expand Down
Loading