Skip to content

Fix #715: Properly propagate install errors in TUI #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kyleclarktech wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #715: Properly propagate install errors in TUI #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deployment/Single Host/Station-Captain/src/lib/PackageManagement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def installPackages(packages:list) -> (bool, str):
if result.returncode != 0:
PackageManagement.log.error("Failed to run install packages command: %s", result.stderr)
return False, result.stderr
return True
return True, None

@staticmethod
def removePackages(packages:list) -> (bool, str):
Expand All @@ -83,19 +83,19 @@ def removePackages(packages:list) -> (bool, str):
if result.returncode != 0:
PackageManagement.log.error("Failed to run remove packages command: %s", result.stderr)
return False, result.stderr
return True
return True, None

@staticmethod
def installCore():
# TODO:: update to use new install, package get features
# TODO:: update with error handling, return
def installCore() -> tuple[bool, str]:
PackageManagement.log.info("Installing core components.")
# TODO:: will likely need updated for yum
result = PackageManagement.runPackageCommand("update")
result = PackageManagement.runPackageCommand("install", PackageManagement.BASE_STATION_PACKAGE, "-y")
PackageManagement.log.debug("Result of install: " + result.stdout)
if result.returncode != 0:
PackageManagement.log.error("FAILED to install core components: %s", result.stderr)
return False, result.stderr
return True, None

@staticmethod
def updateSystem() -> (bool, str):
Expand Down
7 changes: 5 additions & 2 deletions deployment/Single Host/Station-Captain/src/lib/UserInteraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,8 +876,11 @@ def setupWizard(self):
else:
UserInteraction.log.info("User chose to install core components.")
self.dialog.infobox("Installing core components. Please wait.")
PackageManagement.installCore()
self.dialog.msgbox("Core components installed!", title="Setup Wizard")
success, error = PackageManagement.installCore()
if success:
self.dialog.msgbox("Core components installed!", title="Setup Wizard")
else:
self.dialog.msgbox("Failed to install core components:\n\n" + str(error), title="Setup Wizard - Error")

# TODO: set simple settings; domain name, run by details, email settings

Expand Down