Conversation
csvance
force-pushed
the
feature/executable-serialization-julia
branch
from
September 22, 2026 13:13
05ee594 to
adea978
Compare
…ory stats (Julia) Julia side of the shims added to libReactantExtra in EnzymeAD#3277: XLA.serialize_executable, XLA.load_serialized_executable, XLA.clear_memory_stats!, XLA.compiled_memory_stats and the CompiledMemoryStats struct, with PJRT and IFRT methods and Thunk conveniences for serialize and compiled stats. The serialized bytes take ownership of the malloc'd buffer through unsafe_wrap(...; own=true) instead of being copied. test/core/executable_serialization.jl: round trip with bit-identical results, compile-options override, invalid bytes, memory stats, stats reset. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0187bPmjLReauAiN6YP2a3cd
csvance
force-pushed
the
feature/executable-serialization-julia
branch
from
September 22, 2026 13:30
adea978 to
799af3b
Compare
csvance
marked this pull request as ready for review
September 22, 2026 14:25
wsmoses
approved these changes
Sep 22, 2026
Member
|
Collaborator
Author
|
@wsmoses looks like a name collision, fixing now. |
Pangoraw
reviewed
Sep 24, 2026
Pangoraw
left a comment
Collaborator
There was a problem hiding this comment.
some comments about unnecessary @preserve, may not be caused by this PR but would be nice to clean at some point (also for all the device.device)
Pangoraw
approved these changes
Sep 24, 2026
Collaborator
Author
|
Looks like a memory stats test is failing on TPU, taking a look at that now: https://github.com/EnzymeAD/Reactant.jl/actions/runs/36016679351/job/107692793412?pr=3305 EDIT: the test is broken for TPU, rebasing and pushing a fix shortly. |
Only the CPU device lacks allocator statistics; TPU supports the reset, matching the existing allocatorstats test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia part of the changes originally contained in #3277