[EAN-Issue-2530] Added emv-contracts-details move module by aregng · Pull Request #342 · Entropy-Foundation/aptos-core

aregng · 2026-03-10T08:29:19Z

The module will hold the evm contract names associated with the corresponding addresses
Supra node runtime will utilize this information to retrieve evm block-metadata and automation-registry contract addresses
Users can retrieve the 0x1::evm_contracts_details::EvmContractsDetails resource to get info on supra native evm contracts

Fixes: https://github.com/Entropy-Foundation/smr-moonshot/issues/2530

…Foundation/aptos-core into feature/dkg-integration

* feat(types,accumulator): Add features for transactions inclusions and events emissions proofs. - RLP's `Encodable` trait implementation for Contract Events. - `get_proof_by_position` method for Merkle Accumulator. * feat: add `EventV2` api type * chore: cargo feature optimization * refactor(aptos-api-types): transformed `Event` to `EventV1` and applied Full-Clone on `EventV2` * feat: add `hash` in `EventV1` with serialization disabled * docs: fix oai docs for `EventV1` * feat(aptos_api_types): add `try_into_v2_events` to convert `ContractEvent` to `EventV2` * feat: add `SUPRA_TRANSACTIONS_INCLUSION_PROOFS` feature flag * feat: replace rlp encoding with custom encoding to generate event hash * chore: replace `alloy` with `sha3` for `Keccak256` impl * fix: Keccack256 hash implementation using `sha3` --------- Co-authored-by: Nikita Puzankov <n.puzankov@supraoracles.com> Co-authored-by: Simon Chen <s.chen@supraoracles.com>

…-qualified SSH submodule refs.

… the outcome of https://vote.supra.com/proposal/3. (#344)

- The module will hold the evm contract names accosiated with the corresponding addresses - Supra node runtime will utilize this information to retrieve evm block-metadata and automation-registry contract addresses - Users can retrieve the 0x1::evm_contracts_details::EvmContractsDetails resource to get info on supra native evm contracts

sjoshisupra · 2026-03-26T06:39:51Z

aptos-move/framework/supra-framework/sources/configs/evm_contracts_details.move

+    /// supra_framework::evm_genesis_config::set_for_next_epoch(&framework_signer, vector["contact1_name"], [contract1_address]);
+    /// supra_framework::supra_governance::reconfigure(&framework_signer);
+    /// ```
+    public fun upset_for_next_epoch(account: &signer, keys: vector<String>, values: vector<address>) acquires EvmContractsDetails {


Suggested change

public fun upset_for_next_epoch(account: &signer, keys: vector<String>, values: vector<address>) acquires EvmContractsDetails {

public fun upsert_for_next_epoch(account: &signer, keys: vector<String>, values: vector<address>) acquires EvmContractsDetails {

sjoshisupra · 2026-03-26T06:41:59Z

aptos-move/framework/supra-framework/sources/configs/evm_contracts_details.move

+    public(friend) fun on_new_epoch(framework: &signer) acquires EvmContractsDetails {
+        system_addresses::assert_supra_framework(framework);
+        if (config_buffer::does_exist<EvmContractsDetails>()) {
+            let new_config = config_buffer::extract<EvmContractsDetails>();


is this compatible with another PR that @supra-yoga worked on ? Essentially this config_buffer::extract is an unprotected extraction flagged by auditor so we have extract_v2 somewhere which takes framework signer. This is going to conflict with that.

sjoshisupra · 2026-03-26T06:45:30Z

aptos-move/framework/supra-framework/sources/dkg_committee.move

+    /// Input for DKG key output - contains threshold type and keys for one committee
+    struct DkgCommitteeOutput has copy, drop {
+        /// The threshold type (0=validity, 1=quorum, 2=unanimous, etc.)
+        threshold_type: u8,
+        /// Public key shares for each validator (indexed by validator position)
+        keys: vector<vector<u8>>,
+    }


struct should be before any method as a standard practice in Move modules

sjoshisupra · 2026-03-26T06:47:13Z

aptos-move/framework/supra-framework/sources/dkg_committee.move

+    public fun new_dkg_node_config(addr: address, identity: vector<u8>, dkg_pubkey: vector<u8>,): DkgNodeConfig{
+        DkgNodeConfig{
+            addr,
+            identity,
+            dkg_pubkey
+        }
+    }
+
+    public fun get_addr(dkg_node: &DkgNodeConfig): address{
+        dkg_node.addr
+    }
+
+    public fun get_dkg_pubkey(dkg_node: &DkgNodeConfig): vector<u8>{
+        dkg_node.dkg_pubkey
+    }
+
+    public fun len(committee: &DkgCommittee): u64{
+        vector::length(&committee.committee)
+    }
+
+    public fun get_committee(dkg_committee: &DkgCommittee): vector<DkgNodeConfig>{
+        dkg_committee.committee
+    }
+
+    public fun new_dkg_committee(committee: vector<DkgNodeConfig>, threshold_type: CertificateThresholdType): DkgCommittee{
+
+        assert!(vector::length(&committee) > 0, EINVALID_DKG_COMMITTEE_SIZE);
+        DkgCommittee{
+            committee,
+            threshold_type
+        }
+    }
+
+    public fun new_dkg_committee_from_validator_consensus_info(validator_committee: vector<ValidatorConsensusInfo>, threshold_type: CertificateThresholdType): DkgCommittee{
+
+        assert!(vector::length(&validator_committee) > 0, EINVALID_DKG_COMMITTEE_SIZE);
+
+        // The order of the committee members is important for DKG.
+        // The order should correspond to the order of the validator committee.
+        // The output of the DKG has keys in the same order as the committee.
+        let dkg_committee = vector[];
+        vector::for_each(validator_committee, |x|
+            {
+                let validator_keys_bytes = validator_consensus_info::get_pk_bytes(&x);
+                let addr = validator_consensus_info::get_addr(&x);
+                vector::push_back(&mut dkg_committee, DkgNodeConfig{
+                    addr,
+                    identity: bcs::to_bytes(&addr),
+                    dkg_pubkey: validator_keys_bytes,
+                });
+            }
+        );
+
+        DkgCommittee{
+            committee: dkg_committee,
+            threshold_type
+        }
+    }
+
+    public fun new_receiver_committee(is_resharing: bool, dkg_threshold_type: CertificateThresholdType, committee: DkgCommittee): ReceiverCommittee{
+        ReceiverCommittee{


I think all of the methods here are pure functions so should either be tagged as view or perhaps use public(friend) if this is to be invoked only from other module? Not sure what purpose is served by this module since Move state is not changed at all. If this is only for validators, wouldn't it make more sense to do this in rust layer?

sjoshisupra · 2026-03-26T06:49:36Z

aptos-move/framework/supra-framework/sources/stake.move

    use supra_framework::system_addresses;
    use supra_framework::staking_config::{Self, StakingConfig, StakingRewardsConfig};
    use supra_framework::chain_status;
+    use std::dkg_committee;


use supra_framework::dkg_committee

sjoshisupra · 2026-03-26T07:29:23Z

aptos-move/framework/supra-framework/sources/dkg.move

+        let len = vector::length(&public_key_shares_all_comms.commitments);
+        while (i < len) {
+            let commitment = vector::borrow(&public_key_shares_all_comms.commitments, i);
+            // As the first index contains the committee's threshold public key, we can skip that
+            let evals = vector::slice(&commitment.bls12381_commitment_evals, 1, vector::length(&commitment.bls12381_commitment_evals));
+
+            vector::push_back(
+                &mut committee_outputs,
+                new_dkg_committee_output(commitment.threshold_type, evals)
+            );
+            i = i + 1;
+        };


if the vector is ok to be destroyed use vector::for_each_reverse otherwise use vector::for_each_ref, in general use functional style vector operations available in vector.move

sjoshisupra · 2026-03-26T07:30:01Z

aptos-move/framework/supra-framework/sources/dkg.move

    }

+    /// Return the last completed DKG session state, if it exists.
+    public fun last_completed_session(): Option<DKGSessionState> acquires DKGState {


Should this be public fun or public(friend) fun?

if it should be public fun then should be tagged as view

sjoshisupra · 2026-03-26T07:38:05Z

types/src/on_chain_config/automation_registry.rs

+// Copyright (c) Aptos Foundation
+// SPDX-License-Identifier: Apache-2.0
+


Not sure why Aptos Foundation header got added, is this auto generated?

sjoshisupra · 2026-03-26T07:38:44Z

types/src/on_chain_config/evm_genesis_config.rs

+// Copyright (c) Aptos Foundation
 // SPDX-License-Identifier: Apache-2.0



Again, not sure why this got added as header, this is purely SUPRA code

sjoshisupra · 2026-03-26T07:39:40Z

types/src/transaction/automation.rs

+// Copyright (c) Aptos Foundation
+// SPDX-License-Identifier: Apache-2.0
+


Purely supra code, remove this header, not sure why this got added

hsaleemsupra added 30 commits August 12, 2025 16:27

update validator pub keys to support dkg

47f6569

adds blockmetadata flag

b765729

featureflag for blockmetadataext

451f716

add consenses_key support for past version

af3aa8a

add clan, family committee structure

5a1c866

update dkg module to handle new dkg

5801978

change dkg.move to use DkgNodeConfig

d1c7590

on going changes

dcad926

moved dkg transaction validation to aptosvm

cbf7cc6

adds dkg transaction to post bls pk shares

439f93c

removed author from dkgmeta

c3b7468

supra dkg feature flag

4aca943

update validator pub keys to support dkg

71a505e

adds blockmetadata flag

769589e

featureflag for blockmetadataext

353fd73

add consenses_key support for past version

7051fa1

add clan, family committee structure

ea317d2

update dkg module to handle new dkg

7496465

change dkg.move to use DkgNodeConfig

3787d0f

on going changes

7a659f5

moved dkg transaction validation to aptosvm

ed6d5b1

adds dkg transaction to post bls pk shares

620029f

removed author from dkgmeta

c38ce7b

supra dkg feature flag

1b5a784

rebase with dev

33e0b87

Merge branch 'feature/dkg-integration' of https://github.com/Entropy-…

d580810

…Foundation/aptos-core into feature/dkg-integration

add dkg validator transaction validation

31b13ce

adds family check in dkg transaction validation

9a06c1c

minor

44d8ace

adds feature gating for validator transaction execution

5527465

hsaleemsupra and others added 21 commits January 15, 2026 09:55

add supra_stdlib gas params to_on_chain_gas_schedule

5225a84

add randomness tag to block_prologue_ext

42ff45d

temporarily mark randomness biasable

9f3433c

add SUPRA_DKG to default features

bcc44ad

dkg module fixes

f04b953

fix dkg transactions error handling in vm

5f41e34

added dkg config

56ef591

dkg handles all bls key types

3fd373f

remove dkg meta set condition for pk shares

0ccc796

adds dkg threshold type for receiver committees

24000f8

removed error status DKG_META_NOT_SET

4e6e46c

distinguish error code for future/past epochs

79a96ab

Merge from dev

1e71f67

fixed leader ban test cases

44fe773

dkg for bcft and clan majority

3c7de8d

update crypto version

6465022

adds next_epoch_validator_consensus_infos_for_dkg

bf8d3b2

fix: ensure hash_bytes gets updated with finalized hash

2110584

Updated crypto ref to revision containing ref to bicycl-rs with fully…

4f9d312

…-qualified SSH submodule refs.

update crypto

1babded

aregng requested review from isaacdoidge and sjoshisupra March 10, 2026 08:29

Updated minimum GAS_UNIT_PRICE from 100 to 100_000 in accordance with…

8327156

… the outcome of https://vote.supra.com/proposal/3. (#344)

aregng force-pushed the task/issue-2530 branch from 0b0d3c0 to 31a63cb Compare March 20, 2026 09:16

hsaleemsupra and others added 3 commits March 24, 2026 17:56

Merge branch 'dev' into feature/dkg-integration

d7ca84f

test fixes

a692139

aregng force-pushed the task/issue-2530 branch from 31a63cb to 0cf508d Compare March 25, 2026 11:30

sjoshisupra requested changes Mar 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EAN-Issue-2530] Added emv-contracts-details move module#342

[EAN-Issue-2530] Added emv-contracts-details move module#342
aregng wants to merge 107 commits intodevfrom
task/issue-2530

aregng commented Mar 10, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

sjoshisupra Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	public fun upset_for_next_epoch(account: &signer, keys: vector<String>, values: vector<address>) acquires EvmContractsDetails {
	public fun upsert_for_next_epoch(account: &signer, keys: vector<String>, values: vector<address>) acquires EvmContractsDetails {

		// Copyright (c) Aptos Foundation
		// SPDX-License-Identifier: Apache-2.0

Conversation

aregng commented Mar 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants