8157 remove cypress nx generator - DO NOT MERGE UNTIL V2.0.7 published with deprecation notice#324
Open
ninjagirl888 wants to merge 9 commits intomainfrom
Open
8157 remove cypress nx generator - DO NOT MERGE UNTIL V2.0.7 published with deprecation notice#324ninjagirl888 wants to merge 9 commits intomainfrom
ninjagirl888 wants to merge 9 commits intomainfrom
Conversation
…ight. (confirmed in files packages\playwright\)
Danphillipz
requested changes
Oct 22, 2024
Member
Danphillipz
left a comment
There was a problem hiding this comment.
I will give this a proper review in the morning. But immediately I'd say we do not want to delete our cypress generator. We're just removing support for it, as such it needs to be marked as deprecated in documentation (i.e the Cypress plugin readme and official stacks docs).
So the only deletions we should be doing is where we have the option to scaffold something with Cypress.
JackMidd-Amido
previously approved these changes
Oct 22, 2024
…r tests on pipeline test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until
https://github.com/Ensono/stacks-nx-plugins/actions/runs/11551312478 published to npm as v 2.0.7
📲 What
I want to remove the nx generator for Cypress tests
🤔 Why
Cypress is no longer supported within Stacks so we need to remove it from the NX Generator plugins.
🛠 How
These are the folders containing the cypress plugin: - remove
https://github.com/Ensono/stacks-nx-plugins/tree/main/packages/cypress
https://github.com/Ensono/stacks-nx-plugins/tree/main/e2e/cypress-e2e
This is the documentation that refers to the Cypress plugin - update
[https://github.com/Ensono/stacks-nx-plugins/blob/main/CONTRIBUTING.md?plain=1#L135]
Update other files that have references to Cypress - these will include e2e, configuration type files.
👀 Evidence
Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR
🕵️ How to test
Notes for QA
✅ Acceptance criteria Checklist