chore: remove dead code + stop shipping dev sample WAVs - #35
Merged
Merged
Conversation
Lean-down (#22): delete the two never-imported hooks useStarredTracks and usePlaylist, three unused CSS rules (.backbtn, .searchbar__clear, .view__head--row), and the unused --dock-h custom property. (storageEstimate is kept — it's now used by the import quota check.) PWA hygiene (#20): the public/samples/*.wav tones are dev-only seed fixtures but shipped in the build because they live in public/. Add a build-only Vite plugin that strips dist/samples from the production output (~2.7MB). The other #20 checklist items are intentionally skipped: a GitHub Pages deploy workflow is moot (the deploy is Firebase), and iOS splash screens are cosmetic (the dark background_color already covers the launch). Verified: production build succeeds with dist/samples absent and the deleted CSS gone from the bundle; dev still renders the library, search, and rows with no errors. Fixes #22. Fixes #20. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FkDKh1Uo1a4D7n5wCKdcKF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22. Fixes #20.
Lean-down (#22)
Delete provably-dead code (each verified with a repo-wide grep — referenced only at its own definition):
useStarredTracks,usePlaylisthooks (useLibrary.js).backbtn,.searchbar__clear,.view__head--rowCSS rules--dock-hunused custom propertystorageEstimateis kept — it's no longer dead (the import quota check from #26 uses it), exactly the trap flagged in the issue.PWA hygiene (#20)
The
public/samples/*.wavtones are dev-only seed fixtures but shipped in the build because they live inpublic/. Added a build-only Vite plugin that stripsdist/samplesfrom the production output (~2.7 MB the user never plays).The other two #20 checklist items are intentionally skipped: a GitHub Pages deploy workflow is moot (the deploy is Firebase, per #2), and iOS splash screens are cosmetic (the dark
background_coloralready covers the launch).Verification
dist/samplesabsent after buildpublic/samplesintact for dev🤖 Generated with Claude Code
Generated by Claude Code