Skip to content

remove DependsOn that was failing CloudFormation template validation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aripringle wants to merge 1 commit into
base: fix
Choose a base branch
from
Open

remove DependsOn that was failing CloudFormation template validation #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/stackops/apiGateway.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,15 @@ module.exports = function(currentTemplate, aliasStackTemplates, currentAliasStac
}

stageStack.Resources[name] = method;

// Remove DependsOn for LambdaPermissionApiGateway since it is now owned by the alias stack
if (_.isArray(method.DependsOn)) {
_.forEach(method.DependsOn, (val, key) => {
if (_.endsWith(val, 'LambdaPermissionApiGateway')) {
method.DependsOn.splice(key, 1);
}
});
}
});

// Audjust authorizer Uri and name (stage variables are not allowed in Uris here)
Expand Down